feat(eslint): enable @typescript-eslint/no-unnecessary-type-parameters

JoshuaKGoldberg · JoshuaKGoldberg · commit 2795da8fb0e4 · 2026-04-07T16:32:13.000-04:00
diff --git a/eslint.config.ts b/eslint.config.ts
@@ -608,6 +608,7 @@ export default typescript.config([
           '@typescript-eslint/no-for-in-array': 'error',
           '@typescript-eslint/no-unnecessary-template-expression': 'error',
           '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+          '@typescript-eslint/no-unnecessary-type-parameters': 'error',
           '@typescript-eslint/switch-exhaustiveness-check': [
             'error',
             {considerDefaultExhaustiveForUnions: true},
diff --git a/static/app/components/core/compactSelect/utils.tsx b/static/app/components/core/compactSelect/utils.tsx
@@ -36,7 +36,7 @@ export function getSearchConfig<Value extends SelectKey>(
   return search;
 }
 
-export function getEscapedKey<Value extends SelectKey | undefined>(value: Value): string {
+export function getEscapedKey(value: SelectKey): string {
   return CSS.escape(String(value));
 }
 
@@ -287,8 +287,8 @@ export function getSortedItems<Value extends SelectKey>(
  * selected, then this function selects all of them. If all of the options are selected,
  * then this function unselects all of them.
  */
-function toggleOptions<Value extends SelectKey>(
-  optionKeys: Value[],
+function toggleOptions(
+  optionKeys: SelectKey[],
   selectionManager: ListState<any>['selectionManager']
 ) {
   const {selectedKeys} = selectionManager;
diff --git a/static/app/components/events/autofix/preferences/hooks/useOrganizationRepositories.ts b/static/app/components/events/autofix/preferences/hooks/useOrganizationRepositories.ts
@@ -17,9 +17,7 @@ interface Props {
 /**
  * @deprecated Use organizationRepositoriesInfiniteOptions instead.
  */
-export function useOrganizationRepositories<T extends Repository = Repository>(
-  {query = {}} = {} as Props
-) {
+export function useOrganizationRepositories({query = {}} = {} as Props) {
   const queryRef = useRef<Record<string, string>>(query);
   useEffect(() => {
     queryRef.current = query;
@@ -39,15 +37,15 @@ export function useOrganizationRepositories<T extends Repository = Repository>(
     [organization.slug]
   );
 
-  const {pages, isFetching, ...rest} = useFetchSequentialPages<T[]>({
+  const {pages, isFetching, ...rest} = useFetchSequentialPages<Repository[]>({
     getQueryKey,
     perPage: 100,
     enabled: true,
   });
 
   const data = useMemo(() => {
     const flattenedRepos = pages.flat();
-    const uniqueReposMap = new Map<string, T>();
+    const uniqueReposMap = new Map<string, Repository>();
     flattenedRepos.forEach(repo => {
       if (repo.externalId && !uniqueReposMap.has(repo.externalId)) {
         uniqueReposMap.set(repo.externalId, repo);
diff --git a/static/app/components/events/contexts/utils.tsx b/static/app/components/events/contexts/utils.tsx
@@ -133,6 +133,7 @@ export function getRelativeTimeFromEventDateCreated(
 
 type KnownDataDetails = Omit<KeyValueListDataItem, 'key'> | undefined;
 
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
 export function getKnownData<Data, DataType>({
   data,
   knownDataTypes,
diff --git a/static/app/components/events/interfaces/spans/waterfallModel.tsx b/static/app/components/events/interfaces/spans/waterfallModel.tsx
@@ -200,7 +200,6 @@ export class WaterfallModel {
       threshold: 0.6,
       location: 0,
       distance: 100,
-      maxPatternLength: 32,
     });
   }
 
diff --git a/static/app/components/issues/groupList.tsx b/static/app/components/issues/groupList.tsx
@@ -176,7 +176,7 @@ export function GroupList({
   const hasLogicBoolean = useMemo(
     () =>
       parsedQuery
-        ? treeResultLocator<boolean>({
+        ? treeResultLocator({
             tree: parsedQuery,
             noResultValue: false,
             visitorTest: ({token, returnResult}) => {
diff --git a/static/app/components/pipeline/types.tsx b/static/app/components/pipeline/types.tsx
@@ -49,10 +49,11 @@ export interface PipelineStepProps<
 }
 
 /**
- * Identity function that casts the raw completion data to a typed shape.
+ * Identity function that asserts the raw completion data to a typed shape.
  * Avoids the verbose `(data: Record<string, unknown>) => data as unknown as T`
  * boilerplate in every pipeline definition.
  */
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
 export function pipelineComplete<T>(data: Record<string, unknown>): T {
   return data as unknown as T;
 }
diff --git a/static/app/components/searchQueryBuilder/tokens/combobox.tsx b/static/app/components/searchQueryBuilder/tokens/combobox.tsx
@@ -177,15 +177,15 @@ function menuIsOpen({
   return openState && totalOptions > hiddenOptions.size;
 }
 
-function useHiddenItems<T extends SelectOptionOrSectionWithKey<string>>({
+function useHiddenItems({
   items,
   filterValue,
   maxOptions,
   shouldFilterResults,
   showAskSeerOption,
 }: {
   filterValue: string;
-  items: T[];
+  items: Array<SelectOptionOrSectionWithKey<string>>;
   showAskSeerOption: boolean;
   maxOptions?: number;
   shouldFilterResults?: boolean;
diff --git a/static/app/components/searchSyntax/parser.tsx b/static/app/components/searchSyntax/parser.tsx
@@ -886,7 +886,7 @@ export class TokenConverter {
   /**
    * Checks a filter against some non-grammar validation rules
    */
-  checkFilterWarning = <T extends FilterType>(key: FilterMap[T]['key']) => {
+  checkFilterWarning = (key: FilterMap[FilterType]['key']) => {
     if (
       ![
         Token.KEY_SIMPLE,
@@ -1513,10 +1513,12 @@ export const defaultConfig: SearchConfig = {
   },
 };
 
-function tryParseSearch<T extends {config: SearchConfig}>(
-  query: string,
-  config: T
-): ParseResult | null {
+interface SearchParseConfig {
+  [i: string]: any;
+  config: SearchConfig;
+}
+
+function tryParseSearch(query: string, config: SearchParseConfig): ParseResult | null {
   try {
     return parse(query, config);
   } catch (e: any) {
diff --git a/static/app/components/searchSyntax/utils.tsx b/static/app/components/searchSyntax/utils.tsx
@@ -26,11 +26,11 @@ class TokenResultFoundError extends Error {
  */
 const skipTokenMarker = Symbol('Returned to skip visiting a token');
 
-type VisitorFn = (opts: {
+type VisitorFn<T> = (opts: {
   /**
    * Call this to return the provided value as the result of treeResultLocator
    */
-  returnResult: (result: any) => TokenResultFoundError;
+  returnResult: (result: T) => TokenResultFoundError;
   /**
    * Return this to skip visiting any inner tokens
    */
@@ -41,12 +41,12 @@ type VisitorFn = (opts: {
   token: TokenResult<Token>;
 }) => null | TokenResultFoundError | typeof skipTokenMarker;
 
-type TreeResultLocatorOpts = {
+type TreeResultLocatorOpts<T> = {
   /**
    * The value to return when returnValue was never called and all nodes of the
    * search tree were visited.
    */
-  noResultValue: any;
+  noResultValue: T;
   /**
    * The tree to visit
    */
@@ -56,7 +56,7 @@ type TreeResultLocatorOpts = {
    * visiting. May also indicate that we want to skip any further traversal of
    * inner nodes.
    */
-  visitorTest: VisitorFn;
+  visitorTest: VisitorFn<T>;
 };
 
 /**
@@ -72,7 +72,7 @@ export function treeResultLocator<T>({
   tree,
   visitorTest,
   noResultValue,
-}: TreeResultLocatorOpts): T {
+}: TreeResultLocatorOpts<T>): T {
   const returnResult = (result: any) => new TokenResultFoundError(result);
 
   const nodeVisitor = (token: TokenResult<Token> | null) => {
diff --git a/static/app/components/tokenizedInput/token/comboBox.tsx b/static/app/components/tokenizedInput/token/comboBox.tsx
@@ -60,14 +60,14 @@ interface ComboBoxProps {
   tabIndex?: number;
 }
 
-function useHiddenItems<T extends SelectOptionOrSectionWithKey<string>>({
+function useHiddenItems({
   items,
   filterValue,
   maxOptions,
   shouldFilterResults,
 }: {
   filterValue: string;
-  items: T[];
+  items: Array<SelectOptionOrSectionWithKey<string>>;
   maxOptions?: number;
   shouldFilterResults?: boolean;
 }) {
diff --git a/static/app/components/workflowEngine/form/getFormFieldValue.tsx b/static/app/components/workflowEngine/form/getFormFieldValue.tsx
@@ -5,10 +5,10 @@ import type {FieldValue} from 'sentry/components/forms/types';
  * The form values returned by form.getValue are not typed, so this is a
  * convenient helper to do a type assertion while getting the value.
  */
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
 export function getFormFieldValue<T extends FieldValue = FieldValue>(
   form: FormModel,
   field: string
 ): T {
-  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
-  return form.getValue(field) as FieldValue;
+  return form.getValue(field);
 }
diff --git a/static/app/components/workflowEngine/form/useFormField.tsx b/static/app/components/workflowEngine/form/useFormField.tsx
@@ -6,6 +6,7 @@ import {FormContext} from 'sentry/components/forms/formContext';
 import type {FieldValue} from 'sentry/components/forms/types';
 import {getFormFieldValue} from 'sentry/components/workflowEngine/form/getFormFieldValue';
 
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
 export function useFormField<Value extends FieldValue = FieldValue>(
   field: string
 ): Value | undefined {
diff --git a/static/app/stores/hookStore.tsx b/static/app/stores/hookStore.tsx
@@ -15,13 +15,9 @@ type HookCallback = (...args: any[]) => void;
 interface HookStoreDefinition extends StoreDefinition, Internals {
   add<H extends HookName>(hookName: H, callback: Hooks[H]): void;
   get<H extends HookName>(hookName: H): Array<Hooks[H]>;
-  getCallback<H extends HookName>(hookName: H, key: string): HookCallback | undefined;
+  getCallback(hookName: HookName, key: string): HookCallback | undefined;
   init(): void;
-  persistCallback<H extends HookName>(
-    hookName: H,
-    key: string,
-    value: HookCallback
-  ): void;
+  persistCallback(hookName: HookName, key: string, value: HookCallback): void;
   remove<H extends HookName>(hookName: H, callback: Hooks[H]): void;
 }
 
diff --git a/static/app/utils/analytics/makeAnalyticsFunction.tsx b/static/app/utils/analytics/makeAnalyticsFunction.tsx
@@ -18,7 +18,6 @@ type Options = Parameters<Hooks['analytics:raw-track-event']>[1];
  */
 export function makeAnalyticsFunction<
   EventParameters extends Record<string, Record<string, any>>,
-  OrgRequirement extends OptionalOrg = OptionalOrg,
 >(
   eventKeyToNameMap: Record<keyof EventParameters, string | null>,
   defaultOptions?: Options
@@ -31,7 +30,7 @@ export function makeAnalyticsFunction<
    */
   return <EventKey extends keyof EventParameters & string>(
     eventKey: EventKey,
-    analyticsParams: EventParameters[EventKey] & OrgRequirement,
+    analyticsParams: EventParameters[EventKey] & OptionalOrg,
     options?: Options
   ) => {
     const eventName = eventKeyToNameMap[eventKey];
diff --git a/static/app/utils/api/apiOptions.ts b/static/app/utils/api/apiOptions.ts
@@ -34,6 +34,7 @@ export const selectJsonWithHeaders = <TData>(
 ): ApiResponse<TData> => data;
 
 function _apiOptions<
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
   TManualData = never,
   TApiPath extends KnownApiUrls = KnownApiUrls,
   // todo: infer the actual data type from the ApiMapping
@@ -69,6 +70,7 @@ function parsePageParam<TQueryFnData = unknown>(dir: 'previous' | 'next') {
 }
 
 function _apiOptionsInfinite<
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
   TManualData = never,
   TApiPath extends KnownApiUrls = KnownApiUrls,
   // todo: infer the actual data type from the ApiMapping
diff --git a/static/app/utils/api/useAggregatedQueryKeys.tsx b/static/app/utils/api/useAggregatedQueryKeys.tsx
@@ -49,8 +49,8 @@ interface Props<AggregatableQueryKey, Data> {
   onError?: (error: Error) => void;
 }
 
-function isQueryKeyInList<AggregatableQueryKey>(queryList: AggregatableQueryKey[]) {
-  return ({queryKey}: any) => queryList.includes(queryKey[4] as AggregatableQueryKey);
+function isQueryKeyInList(queryList: unknown[]) {
+  return ({queryKey}: any) => queryList.includes(queryKey[4]);
 }
 
 /**
diff --git a/static/app/utils/fuzzySearch.tsx b/static/app/utils/fuzzySearch.tsx
@@ -11,10 +11,10 @@ const DEFAULT_FUSE_OPTIONS: Fuse.IFuseOptions<any> = {
   minMatchCharLength: 2,
 };
 
-export async function createFuzzySearch<
-  T = string,
-  Options extends Fuse.IFuseOptions<T> = Fuse.IFuseOptions<T>,
->(objects: T[], options: Options): Promise<Fuse<T>> {
+export async function createFuzzySearch<T = string>(
+  objects: T[],
+  options: Fuse.IFuseOptions<T>
+): Promise<Fuse<T>> {
   if (!options.keys) {
     throw new Error('You need to define `options.keys`');
   }
@@ -31,10 +31,10 @@ export async function createFuzzySearch<
 // re-export fuse type to make it easier to use
 export type {Fuse};
 
-export function useFuzzySearch<
-  T = string,
-  Options extends Fuse.IFuseOptions<T> = Fuse.IFuseOptions<T>,
->(objects: T[], options: Options): Fuse<T> | null {
+export function useFuzzySearch<T = string>(
+  objects: T[],
+  options: Fuse.IFuseOptions<T>
+): Fuse<T> | null {
   const [fuse, setFuse] = useState<Fuse<T> | null>(null);
 
   useEffect(() => {
diff --git a/static/app/utils/queryClient.tsx b/static/app/utils/queryClient.tsx
@@ -174,6 +174,7 @@ export function fetchDataQuery<TResponseData = unknown>(
  * response data. This does not include the ApiResult type. For that you can
  * manually call queryClient.getQueryData.
  */
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
 export function getApiQueryData<TResponseData>(
   queryClient: QueryClient,
   queryKey: ApiQueryKey
diff --git a/static/app/utils/url/useLocationQuery.tsx b/static/app/utils/url/useLocationQuery.tsx
@@ -41,6 +41,7 @@ type Decoder = KnownDecoder | GenericDecoder;
  */
 export function useLocationQuery<
   InferredRequestShape extends Record<string, Scalar | Scalar[] | Decoder>,
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
   InferredResponseShape extends {
     readonly [Property in keyof InferredRequestShape]: InferredRequestShape[Property] extends Decoder
       ? ReturnType<InferredRequestShape[Property]>
diff --git a/static/app/utils/useLocalStorageState.ts b/static/app/utils/useLocalStorageState.ts
@@ -9,7 +9,8 @@ const SUPPORTS_LOCAL_STORAGE = window && 'localStorage' in window;
 // Attempt to parse JSON. If it fails, swallow the error and return null.
 // As an improvement, we should maybe allow users to intercept here or possibly use
 // a different parsing function from JSON.parse
-function tryParseStorage<T>(jsonEncodedValue: string): T | null {
+// eslint-disable-next-line @typescript-eslint/no-restricted-types
+function tryParseStorage(jsonEncodedValue: string): object | null {
   try {
     return JSON.parse(jsonEncodedValue);
   } catch (e) {
@@ -83,7 +84,7 @@ function initializeStorage<S>(
   }
 
   // We may have failed to parse the value, so just pass it down raw to the initializer
-  const decodedValue = tryParseStorage<S>(jsonEncodedValue);
+  const decodedValue = tryParseStorage(jsonEncodedValue) as S | null;
   if (decodedValue === null) {
     return defaultOrInitializer(defaultValueOrInitializeFn, undefined, jsonEncodedValue);
   }
diff --git a/static/app/utils/useParams.tsx b/static/app/utils/useParams.tsx
@@ -75,6 +75,7 @@ type ParamKeys =
  * const params = useParams<{projectId: string}>();
  * ```
  */
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters
 export function useParams<P extends Partial<Record<ParamKeys, string | undefined>>>(): P {
   const contextParams = useReactRouter6Params() as P;
 
diff --git a/static/app/utils/useSessionStorage.tsx b/static/app/utils/useSessionStorage.tsx
@@ -4,7 +4,7 @@ import {sessionStorageWrapper} from 'sentry/utils/sessionStorage';
 
 const isBrowser = typeof window !== 'undefined';
 
-export function readStorageValue<T>(key: string, initialValue: T) {
+export function readStorageValue(key: string, initialValue: unknown) {
   const value = sessionStorageWrapper.getItem(key);
 
   // We check for 'undefined' because the value may have
diff --git a/static/app/utils/withDomainRedirect.tsx b/static/app/utils/withDomainRedirect.tsx
@@ -33,8 +33,9 @@ import {useOrganization} from './useOrganization';
  * If either a customer domain is not being used, or if :orgId is not present in the route path, then WrappedComponent
  * is rendered.
  */
-export function withDomainRedirect<P>(WrappedComponent: RouteComponent) {
-  return function WithDomainRedirectWrapper(props: P) {
+export function withDomainRedirect(WrappedComponent: RouteComponent) {
+  // eslint-disable-next-line @typescript-eslint/no-restricted-types
+  return function WithDomainRedirectWrapper(props: object) {
     const {customerDomain, links, features} = ConfigStore.getState();
     const {sentryUrl} = links;
     const currentOrganization = useOrganization({allowNull: true});
diff --git a/static/app/utils/withDomainRequired.tsx b/static/app/utils/withDomainRequired.tsx
@@ -30,8 +30,9 @@ import {useParams} from 'sentry/utils/useParams';
  *
  * Whenever https://orgslug.sentry.io/ is accessed in the browser, then both conditions above will be satisfied.
  */
-export function withDomainRequired<P>(WrappedComponent: RouteComponent) {
-  return function WithDomainRequiredWrapper(props: P) {
+export function withDomainRequired(WrappedComponent: RouteComponent) {
+  // eslint-disable-next-line @typescript-eslint/no-restricted-types
+  return function WithDomainRequiredWrapper(props: object) {
     const params = useParams();
     const {features, customerDomain, links} = ConfigStore.getState();
     const {sentryUrl} = links;
diff --git a/static/app/views/insights/pages/agents/components/aiSpanList.tsx b/static/app/views/insights/pages/agents/components/aiSpanList.tsx
diff --git a/static/app/views/insights/pages/agents/hooks/useAITrace.tsx b/static/app/views/insights/pages/agents/hooks/useAITrace.tsx
diff --git a/static/app/views/navigation/primary/organizationDropdown.spec.tsx b/static/app/views/navigation/primary/organizationDropdown.spec.tsx
diff --git a/static/app/views/performance/newTraceDetails/traceModels/traceTreeNode/baseNode.tsx b/static/app/views/performance/newTraceDetails/traceModels/traceTreeNode/baseNode.tsx
diff --git a/static/app/views/performance/newTraceDetails/traceRenderers/traceRowWidthMeasurer.tsx b/static/app/views/performance/newTraceDetails/traceRenderers/traceRowWidthMeasurer.tsx
diff --git a/static/app/views/settings/organizationRelay/modals/modalManager.tsx b/static/app/views/settings/organizationRelay/modals/modalManager.tsx
diff --git a/static/gsAdmin/schemas/broadcasts.tsx b/static/gsAdmin/schemas/broadcasts.tsx
diff --git a/static/gsApp/utils/rawTrackAnalyticsEvent.tsx b/static/gsApp/utils/rawTrackAnalyticsEvent.tsx
diff --git a/static/gsApp/utils/trackGetsentryAnalytics.tsx b/static/gsApp/utils/trackGetsentryAnalytics.tsx
diff --git a/static/gsApp/utils/trackSpendVisibilityAnalytics.tsx b/static/gsApp/utils/trackSpendVisibilityAnalytics.tsx
diff --git a/static/gsApp/views/subscriptionPage/pendingChanges.tsx b/static/gsApp/views/subscriptionPage/pendingChanges.tsx

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,6 @@ export class WaterfallModel {`
`200`	`200`	`threshold: 0.6,`
`201`	`201`	`location: 0,`
`202`	`202`	`distance: 100,`
`203`		`- maxPatternLength: 32,`
`204`	`203`	`});`
`205`	`204`	`}`
`206`	`205`
Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,11 @@ export interface PipelineStepProps<`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/**`
`52`		`- * Identity function that casts the raw completion data to a typed shape.`
	`52`	`+ * Identity function that asserts the raw completion data to a typed shape.`
`53`	`53`	* Avoids the verbose `(data: Record<string, unknown>) => data as unknown as T`
`54`	`54`	`* boilerplate in every pipeline definition.`
`55`	`55`	`*/`
	`56`	`+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-parameters`
`56`	`57`	`export function pipelineComplete<T>(data: Record<string, unknown>): T {`
`57`	`58`	`return data as unknown as T;`
`58`	`59`	`}`