Skip to content

feat(gitlab): Add API pipleine flag #112367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanpurkhiser merged 1 commit into from
Apr 7, 2026
+1 −0
Merged

feat(gitlab): Add API pipleine flag #112367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ def register_temporary_features(manager: FeatureManager) -> None:
manager.add("organizations:scm-source-context", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# API-driven integration setup pipeline (per-provider rollout)
manager.add("organizations:integration-api-pipeline-github", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
manager.add("organizations:integration-api-pipeline-gitlab", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
Copy link
Copy Markdown
Contributor

@sentry sentry bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new backend feature flag organizations:integration-api-pipeline-gitlab is exposed to the API but lacks the required frontend implementation, rendering it non-functional.
Severity: MEDIUM

Suggested Fix

Either remove the organizations:integration-api-pipeline-gitlab feature flag until the frontend implementation is ready, or add the required frontend code. This includes adding a 'gitlab' entry to the API_PIPELINE_FEATURE_FLAGS map and registering a gitlabIntegrationPipeline in the frontend pipeline registry.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/features/temporary.py#L146

Potential issue: The new feature flag `organizations:integration-api-pipeline-gitlab` is
registered in the backend with `api_expose=True`, indicating it should be used by the
frontend. However, the corresponding frontend implementation is missing. The
`API_PIPELINE_FEATURE_FLAGS` map in
`static/app/views/settings/organizationIntegrations/addIntegration.tsx` lacks an entry
for 'gitlab'. This causes the `getApiPipelineProvider` function to return `null`,
forcing a fallback to the legacy popup-based integration flow. As a result, enabling the
feature flag has no effect on GitLab integration setup.

Did we get this right? 👍 / 👎 to inform future reviews.

# Project Management Integrations Feature Parity Flags
manager.add("organizations:integrations-github_enterprise-project-management", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
manager.add("organizations:integrations-gitlab-project-management", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
Expand Down
Loading