Skip to content

feat(gitlab): Add API pipleine flag#112367

Merged
evanpurkhiser merged 1 commit intomasterfrom
evanpurkhiser/feat-gitlab-add-api-pipleine-flag
Apr 7, 2026
Merged

feat(gitlab): Add API pipleine flag#112367
evanpurkhiser merged 1 commit intomasterfrom
evanpurkhiser/feat-gitlab-add-api-pipleine-flag

Conversation

@evanpurkhiser
Copy link
Copy Markdown
Member

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 7, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2026
@evanpurkhiser evanpurkhiser requested a review from a team April 7, 2026 15:27
manager.add("organizations:scm-source-context", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# API-driven integration setup pipeline (per-provider rollout)
manager.add("organizations:integration-api-pipeline-github", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
manager.add("organizations:integration-api-pipeline-gitlab", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new backend feature flag organizations:integration-api-pipeline-gitlab is exposed to the API but lacks the required frontend implementation, rendering it non-functional.
Severity: MEDIUM

Suggested Fix

Either remove the organizations:integration-api-pipeline-gitlab feature flag until the frontend implementation is ready, or add the required frontend code. This includes adding a 'gitlab' entry to the API_PIPELINE_FEATURE_FLAGS map and registering a gitlabIntegrationPipeline in the frontend pipeline registry.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/features/temporary.py#L146

Potential issue: The new feature flag `organizations:integration-api-pipeline-gitlab` is
registered in the backend with `api_expose=True`, indicating it should be used by the
frontend. However, the corresponding frontend implementation is missing. The
`API_PIPELINE_FEATURE_FLAGS` map in
`static/app/views/settings/organizationIntegrations/addIntegration.tsx` lacks an entry
for 'gitlab'. This causes the `getApiPipelineProvider` function to return `null`,
forcing a fallback to the legacy popup-based integration flow. As a result, enabling the
feature flag has no effect on GitLab integration setup.

Did we get this right? 👍 / 👎 to inform future reviews.

@evanpurkhiser evanpurkhiser merged commit 4d90122 into master Apr 7, 2026
81 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-gitlab-add-api-pipleine-flag branch April 7, 2026 16:03
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants