Skip to content

fix(tests): stabilize flaky React Native metrics onboarding test #112000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaKGoldberg wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Open

fix(tests): stabilize flaky React Native metrics onboarding test #112000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions static/app/gettingStartedDocs/react-native/metrics.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import {OrganizationFixture} from 'sentry-fixture/organization';
import {ProjectFixture} from 'sentry-fixture/project';
import {ProjectKeysFixture} from 'sentry-fixture/projectKeys';

import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
import {
render,
screen,
userEvent,
waitForElementToBeRemoved,
} from 'sentry-test/reactTestingLibrary';

import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
Expand Down Expand Up @@ -41,6 +46,8 @@ describe('getting started with react-native', () => {
/>
);

await waitForElementToBeRemoved(() => screen.queryByTestId('loading-indicator'));
Comment thread
JoshuaKGoldberg marked this conversation as resolved.

expect(
await screen.findByRole('heading', {name: /install sentry/i})
).toBeInTheDocument();
Expand All @@ -50,11 +57,11 @@ describe('getting started with react-native', () => {
).toBeInTheDocument();

// Goes to the configure step
await userEvent.click(screen.getByRole('button', {name: 'Next'}));
await userEvent.click(await screen.findByRole('button', {name: 'Next'}));
expect(await screen.findByText(/Metrics are enabled by default/)).toBeInTheDocument();

// Goes to the verify step
await userEvent.click(screen.getByRole('button', {name: 'Next'}));
await userEvent.click(await screen.findByRole('button', {name: 'Next'}));
expect(await screen.findByText(/Sentry\.metrics\.count/)).toBeInTheDocument();
expect(screen.getByText(/Sentry\.metrics\.gauge/)).toBeInTheDocument();
});
Expand Down
Loading