fix(tests): stabilize flaky React Native metrics onboarding test#112000
Open
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Open
fix(tests): stabilize flaky React Native metrics onboarding test#112000JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
added
the
Frontend: Rerun Flaky Tests
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
JoshuaKGoldberg
changed the base branch from
fix/flaky-test-rerun-infra
to
master
JoshuaKGoldberg
force-pushed
the
fix/flaky-react-native-metrics-spec-v2
branch
from
0d768cc to
9cf0d3b
Compare
JoshuaKGoldberg
removed
the
Frontend: Rerun Flaky Tests
JoshuaKGoldberg
added
the
Frontend: Rerun Flaky Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is slow because the component does asynchronous dynamic importing. That can take a long time under CI load, along with added cumulative time with two
userEvent.clickinteractions.This fix adds more asynchronous waiting assertions within the test:
getByto asynchronousfindByFixes ENG-7206
Made with Cursor