Skip to content

fix(test): stabilize flaky SpansSearchBar onSearch test #111904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 4 commits into from
Apr 8, 2026
+9 −8
Merged

fix(test): stabilize flaky SpansSearchBar onSearch test #111904

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fea44f9
fix(test): Fix flaky SpansSearchBar onSearch test
JoshuaKGoldberg Mar 30, 2026
58ff99b
fix: also the onClose test
JoshuaKGoldberg Apr 1, 2026
102c3bb
normalize calls
JoshuaKGoldberg Apr 8, 2026
0610b17
one more delay:null
JoshuaKGoldberg Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ...c/app/views/dashboards/widgetBuilder/buildSteps/filterResultsStep/spansSearchBar.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,10 @@ describe('SpansSearchBar', () => {
const searchInput = await screen.findByRole('combobox', {
name: 'Add a search term',
});
await userEvent.click(searchInput);
await userEvent.type(searchInput, 'span.op:', {delay: null});
await userEvent.keyboard('function', {delay: null});
await userEvent.keyboard('{enter}');
await userEvent.keyboard('{enter}', {delay: null});

await waitFor(() => {
expect(onSearch).toHaveBeenCalledWith(
Expand All @@ -146,9 +147,7 @@ describe('SpansSearchBar', () => {
});
});

// TODO(nikki): Flaky test
// eslint-disable-next-line jest/no-disabled-tests
it.skip('triggers onClose when the query changes', async () => {
it('triggers onClose when the query changes', async () => {
const onClose = jest.fn();

renderWithProvider({
Expand All @@ -160,10 +159,12 @@ describe('SpansSearchBar', () => {
const searchInput = await screen.findByRole('combobox', {
name: 'Add a search term',
});
await userEvent.type(searchInput, 'span.op:');
await userEvent.keyboard('{enter}');
await userEvent.keyboard('function');
await userEvent.keyboard('{enter}');
await userEvent.click(searchInput);
await userEvent.type(searchInput, 'span.op:', {delay: null});
await userEvent.keyboard('{enter}', {delay: null});
await screen.findByRole('row', {name: /span\.op/});
await userEvent.keyboard('function', {delay: null});
await userEvent.keyboard('{enter}', {delay: null});

await waitFor(() => {
expect(onClose).toHaveBeenCalled();
Expand Down
Loading