fix(test): stabilize flaky SpansSearchBar onSearch test#111904
Merged
JoshuaKGoldberg merged 4 commits intomasterfrom Apr 8, 2026
Merged
fix(test): stabilize flaky SpansSearchBar onSearch test#111904JoshuaKGoldberg merged 4 commits intomasterfrom
JoshuaKGoldberg merged 4 commits intomasterfrom
Conversation
JoshuaKGoldberg
added
Scope: Frontend
JoshuaKGoldberg
force-pushed
the
fix/flaky-spans-search-bar-spec
branch
from
8b59ab0 to
c6a61f7
Compare
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
force-pushed
the
fix/flaky-spans-search-bar-spec
branch
from
c6a61f7 to
6c2a642
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
github-actions
bot
added
the
Scope: Backend
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
JoshuaKGoldberg
changed the base branch from
fix/flaky-test-rerun-infra
to
master
This comment was marked as outdated.
This comment was marked as outdated.
Consolidate multiple separate userEvent calls into a single
userEvent.type call with inline {enter} sequences. The separate calls
caused flaky timeouts because each convenience API call created a new
user-event session, losing focus context between the filter key entry
and value entry steps. Using a single type call keeps the interaction
in one session, matching the pattern used in the SearchQueryBuilder's
own test suite.
Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
Made-with: Cursor
Made-with: Cursor
JoshuaKGoldberg
force-pushed
the
fix/flaky-spans-search-bar-spec
branch
from
340ff8c to
58ff99b
Compare
nikkikapadia
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flaky
onSearchandonClosetests by adding more manual waiting: first an explicit click to focus the element, then making sure the dropdown is populated before hitting enter. I think these more granular waits give the component's async behaviors more time to settle between steps.Fixes ENG-7205
Made with Cursor