chore: Remove graduated feature flag performance-mep-bannerless-ui#111147
chore: Remove graduated feature flag performance-mep-bannerless-ui#111147
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
| if (!dataCounts) { | ||
| return fallbackOutcome; | ||
| } | ||
|
|
There was a problem hiding this comment.
This confused me as to why claude removed it, it's duplicate code
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
Cool thanks! There's one file that looks like it's leaving dead code, but otherwise LGTM 👍🏻
There was a problem hiding this comment.
👀 if this context is truly only used in tests, I think you can delete it!
wedamija
force-pushed
the
danf/ga/perf-landing-widget-flags
branch
from
ac20e98 to
508feb7
Compare
wedamija
force-pushed
the
danf/ga/perf-landing-widget-flags
branch
from
508feb7 to
95ac130
Compare
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
A bit weird that we have that internal export for DashboardsMEPContext, but that code is destined to be deleted completely anyway, when we deprecate the transactions dataset, so not a huge deal
This flag is fully rolled out. Remove the flag registration and simplify all gated code paths: MEP banners, indexed events warnings, and metrics cardinality threshold checks now use the graduated behavior directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove useIndexedEventsWarning entirely (always null) and its callers in widgetCard/index.tsx - Remove IndexedEventsSelectionAlert usage from addToDashboardModal - Remove MetricsDataSwitcherAlert usage from dashboards detail and clean up unused isDashboardUsingTransaction, isWidgetUsingTransactionName, and DiscoverQueryPageSource imports - Un-export getSelectedProjectPlatformsArray (only used internally) - Remove "renders metric fallback alert" test from discover results Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Delete metricsDataSwitcherAlert.tsx (unused file, all callers removed) - Remove isWidgetUsingTransactionName from dashboards/utils.tsx (orphaned export, only consumer was removed) - Remove dead showMetricsAlert state from discover/results.tsx (was set but never read after banner removal) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
All callers were removed in the previous commit; knip flagged the file as unused.
The performance-mep-bannerless-ui flag graduation left dead code: - fromMetric query param handling in discover results - isMetricsData param threaded through getWidgetDiscoverUrl, getMenuOptions, and the query selector modal Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wedamija
force-pushed
the
danf/ga/perf-landing-widget-flags
branch
from
dbf25c7 to
c1ff82d
Compare
…111147) This flag is fully rolled out. Remove the flag registration and simplify all gated code paths: MEP banners, indexed events warnings, and metrics cardinality threshold checks now use the graduated behavior directly. <!-- Describe your PR here. --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Dan Fuller <danfuller@H3FG21463J.local>
2 participants
This flag is fully rolled out. Remove the flag registration and simplify all gated code paths: MEP banners, indexed events warnings, and metrics cardinality threshold checks now use the graduated behavior directly.