fix: Remove dead fromMetric/isMetricsData code paths after flag removal

The performance-mep-bannerless-ui flag graduation left dead code:
- fromMetric query param handling in discover results
- isMetricsData param threaded through getWidgetDiscoverUrl, getMenuOptions,
  and the query selector modal

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 2 people

static/app/components/modals/dashboardWidgetQuerySelectorModal.tsx

@@ -23,7 +23,6 @@ export type DashboardWidgetQuerySelectorModalOptions = {
   dashboardFilters: DashboardFilters | undefined;
   organization: Organization;
   widget: Widget;
-  isMetricsData?: boolean;
 };
 
 type Props = ModalRenderProps &
@@ -34,8 +33,7 @@ type Props = ModalRenderProps &
   };
 
 function DashboardWidgetQuerySelectorModal(props: Props) {
-  const {organization, widget, selection, isMetricsData, Body, Header, dashboardFilters} =
-    props;
+  const {organization, widget, selection, Body, Header, dashboardFilters} = props;
 
   const renderQueries = () => {
     const querySearchBars = widget.queries.map((query, index) => {
@@ -46,9 +44,7 @@ function DashboardWidgetQuerySelectorModal(props: Props) {
         },
         dashboardFilters,
         selection,
-        organization,
-        0,
-        isMetricsData
+        organization
       );
       return (
         <Fragment key={index}>

static/app/components/modals/dataWidgetViewerModal.tsx

@@ -98,10 +98,7 @@ import {
   SESSION_DURATION_ALERT,
   WidgetDescription,
 } from 'sentry/views/dashboards/widgetCard';
-import {
-  DashboardsMEPProvider,
-  useDashboardsMEPContext,
-} from 'sentry/views/dashboards/widgetCard/dashboardsMEPContext';
+import {DashboardsMEPProvider} from 'sentry/views/dashboards/widgetCard/dashboardsMEPContext';
 import type {GenericWidgetQueriesResult} from 'sentry/views/dashboards/widgetCard/genericWidgetQueries';
 import {IssueWidgetQueries} from 'sentry/views/dashboards/widgetCard/issueWidgetQueries';
 import {ReleaseWidgetQueries} from 'sentry/views/dashboards/widgetCard/releaseWidgetQueries';
@@ -907,8 +904,6 @@ function OpenButton({
 }: OpenButtonProps) {
   let openLabel: string;
   let path: string;
-  const {isMetricsData} = useDashboardsMEPContext();
-
   switch (widget.widgetType) {
     case WidgetType.ISSUE:
       openLabel = t('Open in Issues');
@@ -940,9 +935,7 @@ function OpenButton({
         {...widget, queries: [widget.queries[selectedQueryIndex]!]},
         dashboardFilters,
         selection,
-        organization,
-        0,
-        isMetricsData
+        organization
       );
       break;
   }

static/app/views/dashboards/utils.tsx

@@ -209,8 +209,7 @@ export function getWidgetDiscoverUrl(
   dashboardFilters: DashboardFilters | undefined,
   selection: PageFilters,
   organization: Organization,
-  index = 0,
-  isMetricsData = false
+  index = 0
 ) {
   const eventView = eventViewFromWidget(widget.title, widget.queries[index]!, selection);
   const discoverLocation = eventView.getResultsViewUrlTarget(
@@ -272,10 +271,6 @@ export function getWidgetDiscoverUrl(
     dashboardFilters
   );
 
-  if (isMetricsData) {
-    discoverLocation.query.fromMetric = 'true';
-  }
-
   // Pass empty string when projects is empty to preserve "My Projects" selection in URL
   const projectParam =
     selection.projects.length === 0 ? '' : discoverLocation.query.project;

static/app/views/dashboards/widgetCard/index.spec.tsx

@@ -181,7 +181,6 @@ describe('Dashboards > WidgetCard', () => {
     await userEvent.click(await screen.findByLabelText('Widget actions'));
     await userEvent.click(screen.getByRole('menuitemradio', {name: 'Open in Discover'}));
     expect(spy).toHaveBeenCalledWith({
-      isMetricsData: false,
       organization,
       widget: multipleQueryWidget,
     });

static/app/views/dashboards/widgetCard/index.tsx

@@ -55,7 +55,6 @@ import {Widget} from 'sentry/views/dashboards/widgets/widget/widget';
 import {useLLMContext} from 'sentry/views/seerExplorer/contexts/llmContext';
 import {registerLLMContext} from 'sentry/views/seerExplorer/contexts/registerLLMContext';
 
-import {useDashboardsMEPContext} from './dashboardsMEPContext';
 import {VisualizationWidget} from './visualizationWidget';
 import {
   getMenuOptions,
@@ -223,7 +222,6 @@ function WidgetCard(props: Props) {
     query.aggregates.some(aggregate => aggregate.includes('session.duration'))
   );
 
-  const {isMetricsData} = useDashboardsMEPContext();
   const extractionStatus = useExtractionStatus({queryKey: widget});
   const onDemandWarning = useOnDemandWarning({widget});
   const transactionsDeprecationWarning = useTransactionsDeprecationWarning({
@@ -328,7 +326,6 @@ function WidgetCard(props: Props) {
         organization,
         selection,
         widget,
-        Boolean(isMetricsData),
         props.widgetLimitReached,
         props.hasEditAccess,
         location,

static/app/views/dashboards/widgetCard/widgetCardContextMenu.tsx

@@ -167,7 +167,6 @@ export function getMenuOptions(
   organization: Organization,
   selection: PageFilters,
   widget: Widget,
-  isMetricsData: boolean,
   widgetLimitReached: boolean,
   hasEditAccess = true,
   location: Location,
@@ -198,9 +197,7 @@ export function getMenuOptions(
         widget,
         dashboardFilters,
         selection,
-        organization,
-        0,
-        isMetricsData
+        organization
       );
       menuOptions.push({
         key: 'open-in-discover',
@@ -230,7 +227,6 @@ export function getMenuOptions(
           openDashboardWidgetQuerySelectorModal({
             organization,
             widget,
-            isMetricsData,
             dashboardFilters,
           });
         },

static/app/views/discover/results.tsx

@@ -178,15 +178,6 @@ export class Results extends Component<Props, State> {
 
   componentDidMount() {
     const {organization, selection, location, isHomepage, navigate} = this.props;
-    if (location.query.fromMetric) {
-      navigate(
-        {
-          ...location,
-          query: {...location.query, fromMetric: undefined},
-        },
-        {replace: true}
-      );
-    }
     if (location.query[SHOW_UNPARAM_BANNER]) {
       this.setState({showUnparameterizedBanner: true});
       navigate(