Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
|
plugin-dev/Source/Sentry/Private/GenericPlatform/GenericPlatformSentrySubsystem.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
jpnurmi
left a comment
There was a problem hiding this comment.
Should the API use doubles rather than floats?
Integers should be a 64-bit signed integer, while doubles should be a 64-bit floating point number.
Unreal Blueprints do not support the |
This PR adds documentation for the Sentry Metrics feature in the Unreal Engine SDK. Related to: - getsentry/sentry-unreal#1214
This PR adds documentation for the Sentry Metrics feature in the Unreal Engine SDK. Related to: - getsentry/sentry-unreal#1214
To give more info on that, since UE5 blueprint is natively using double for it's floating value (even tho it's naming hasn't been changed) |
This PR adds Sentry Metrics API support to the Unreal plugin with three metric types:
counter,distributionandgauge.Closes #1213
Key changes
AddCount,AddDistributionandAddGaugefunctions to Sentry subsystem interface along with their overloads that allow setting custom metric attributesFSentryMeasurementUnitstruct for type-safe unit specification in Blueprints, covering duration, information, fraction and custom unitsUSentryMetricdata class allowing to read/write individual metric item properties (value, type, unit, attributes)USentryBeforeMetricHandlerhook to filter/edit metrics before sending them to SentryUSentryMetricandUSentryBeforeMetricHandlerfunctionalityPlatform support
Related items
Documentation