Skip to content

Add global attributes support for Android#1274

Merged
tustanivsky merged 8 commits intomainfrom
feat/android-global-attr
Mar 6, 2026
Merged

Add global attributes support for Android#1274
tustanivsky merged 8 commits intomainfrom
feat/android-global-attr

Conversation

@tustanivsky
Copy link
Copy Markdown
Collaborator

@tustanivsky tustanivsky commented Mar 6, 2026

This PR adds global attributes support for Android which was enabled via sentry-java 8.34.0 in #1272.

Key Changes:

  • Added setAttribute/removeAttribute bridge methods in SentryBridgeJava.java delegating to Sentry.setAttribute()/Sentry.removeAttribute()
  • Replaced no-op implementations in AndroidSentrySubsystem.cpp with JNI calls through the Java bridge
  • Added global attribute integration test assertions for logs and metrics on Android (previously skipped as no-op)
  • Added global attribute setup and assertions to the metrics test scenario on both Android and Desktop

Related items:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Internal Changes 🔧

Deps

  • Update Java SDK to v8.34.1 by github-actions in #1272
  • Update CLI to v3.3.0 by github-actions in #1268
  • Update Cocoa SDK to v9.6.0 by github-actions in #1269
  • Update CLI to v3.2.3 by github-actions in #1265
  • Update Native SDK to v0.13.1 by github-actions in #1263
  • Update Cocoa SDK to v9.5.1 by github-actions in #1257

Other

  • Add global attributes support for Android by tustanivsky in #1274
  • Add app hang tracking for Windows and Linux by tustanivsky in #1270
  • Fix screenshot capture error messages during commandlet execution by tustanivsky in #1273
  • Fix debug symbol upload for build products located in the engine directory by tustanivsky in #1262
  • Fix symbol upload configuration warning in plugin settings menu by tustanivsky in #1261

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1e4e34d

@tustanivsky tustanivsky requested review from jpnurmi and limbonaut March 6, 2026 14:04
@tustanivsky tustanivsky merged commit 6184305 into main Mar 6, 2026
177 of 184 checks passed
@tustanivsky tustanivsky deleted the feat/android-global-attr branch March 6, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants