chore: Remove -mno-thumb from Xcode projects for unity-of-bugs
#1921
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #if UNITY_IOS && !UNITY_2021_1_OR_NEWER | ||
| using UnityEditor; | ||
| using UnityEditor.Callbacks; | ||
| using UnityEditor.iOS.Xcode; | ||
| using UnityEngine; | ||
|
|
||
| namespace Editor | ||
| { | ||
| /// <summary> | ||
| /// Unity adds the '-mno-thumb' compiler flag by default to iOS builds, but this flag is outdated | ||
| /// and no longer supported by modern versions of Xcode. Leaving this flag in the project will cause | ||
| /// Xcode builds to fail with an "unsupported option '-mno-thumb' for target" error. This post-process | ||
| /// build step removes the flag to ensure the sample works on all versions of Unity. | ||
| /// </summary> | ||
| public static class XcodeProjectUpdater | ||
| { | ||
| [PostProcessBuild] | ||
| public static void OnPostProcessBuild(BuildTarget target, string pathToBuildProject) | ||
| { | ||
| if (target != BuildTarget.iOS) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| Debug.Log("XcodeUpdater.OnPostProcessBuild started."); | ||
|
|
||
| var pbxProjectPath = PBXProject.GetPBXProjectPath(pathToBuildProject); | ||
| var project = new PBXProject(); | ||
| project.ReadFromFile(pbxProjectPath); | ||
|
|
||
| var targetGuid = project.GetUnityMainTargetGuid(); | ||
|
|
||
| Debug.Log("Removing '-mno-thumb' from 'OTHER_CFLAGS'."); | ||
| project.UpdateBuildProperty(targetGuid, "OTHER_CFLAGS", null, new[] { "-mno-thumb" }); | ||
|
|
||
| project.WriteToFile(pbxProjectPath); | ||
|
|
||
| Debug.Log("XcodeUpdater.OnPostProcessBuild finished."); | ||
| } | ||
| } | ||
| } | ||
| #endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logger doesn't let us opt out or set level right? are we not using our logger here why?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a script that lives outside the SDK and is not part of the shipped package.
It's is purely there to help us run builds locally, when targeting iOS on old Unity versions.