chore: Remove -mno-thumb from Xcode projects for unity-of-bugs
#1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
changed the title
-mno-thumb from Xcode projects for unity-of-bugs
bitsandfoxes
force-pushed
the
chore/sample-no-thumb-update
branch
from
06fc2e5 to
7d1af1a
Compare
bitsandfoxes
commented
Nov 27, 2024
|
|
||
| # Copy samples | ||
| Copy-Item "samples/unity-of-bugs/Assets/Scenes*" -Destination "package-release/Samples~/unity-of-bugs/" -Recurse | ||
| Copy-Item "samples/unity-of-bugs/Assets/Editor*" -Destination "package-release/Samples~/unity-of-bugs/" -Recurse |
Contributor
Author
There was a problem hiding this comment.
We had nothing there in the first place.
| return; | ||
| } | ||
|
|
||
| Debug.Log("XcodeUpdater.OnPostProcessBuild started."); |
Member
There was a problem hiding this comment.
This logger doesn't let us opt out or set level right? are we not using our logger here why?
Contributor
Author
There was a problem hiding this comment.
This is a script that lives outside the SDK and is not part of the shipped package.
It's is purely there to help us run builds locally, when targeting iOS on old Unity versions.
vaind
approved these changes
Nov 27, 2024
Contributor
vaind
left a comment
vaind
left a comment
There was a problem hiding this comment.
Only change to our sample. LGTM 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
With versions 2019 and 2020 Unity exports with a
-mno-thumbflag by default. With the current version of Xcode (16.1) building those projects fails with"unsupported option '-mno-thumb' for target". Those versions of Unity are also out-of-support and won't likely receive an update.How this fixes it
I've added added a
PostProcessBuildthat removes the flag. This allows us to still build for iOS on Unity 2019 and 2020. This script resides inside ofAssets/Editor/and is excluded from being packaged. Endusers will not have his script as part of the package.#skip-changelog