fix: Logging #1900
Merged
fix: Logging #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustanivsky
approved these changes
Nov 13, 2024
| catch (EntryPointNotFoundException e) | ||
| { | ||
| Logger?.LogError(e, "Native dependency not found. Did you delete sentry.dll or move files around?"); | ||
| Logger?.LogError("Native dependency not found. Did you delete sentry.dll or move files around?", e); |
Member
There was a problem hiding this comment.
Is this right? Usually last argument is object[] so it expects a {0} in the string.
The proper logging API has the exception as the first argument
Member
|
What did this PR fix? it's not clear from the title or the description |
| { | ||
| Logger? | ||
| .LogError(e, "Sentry native initialization failed - native crashes are not captured."); | ||
| Logger?.LogError("Sentry native initialization failed - native crashes are not captured.", e); |
Member
There was a problem hiding this comment.
same concern I wrote below
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an attempt to fix an unspecified (now forgotten) compile-error that had to do with the order or arguments.
Update: Cannot reproduce this anymore.
#skip-changelog