Skip to content

chore(s4s): Remove s4s alerting for getsentry/sentry #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzoengineer merged 1 commit into from
Apr 14, 2026
Merged

chore(s4s): Remove s4s alerting for getsentry/sentry #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/brain/gocd/gocdDataDog/deployDatadogEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ export class DeployDatadogEvents {

// Title: GoCD: deploy sha (started/failed/completed) in <insert>-region
const title = `GoCD: deploying <${service}> <${stageName}> <${pipelineResult}> in ${region}`;
// Automatic deploy triggered by <github push?> to track details visit: https://deploy.getsentry.net/go/pipelines/value_stream_map/deploy-getsentry-backend-s4s/2237
// Automatic deploy triggered by <github push?> to track details visit: https://deploy.getsentry.net/go/pipelines/value_stream_map/deploy-getsentry-backend-s4s2/2237
const text = `%%% \n${deploymentReason} from: ${commitShaLink},\n \n ${commitDiffLink} \n GoCD:${stageLink} \n\n *this message was produced by a eng-pipes gocd brain module* \n %%%`;
// Tags: source:gocd customer_name:s4s sentry_region:s4s source_tool:gocd sentry_user:git commit email source_category:infra-tools
const tags = [
Expand Down
2 changes: 1 addition & 1 deletion src/brain/gocd/gocdDataDog/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { GoCDResponse } from '@/types/gocd';
import { DeployDatadogEvents } from './deployDatadogEvents';

// const ENGINEERING_PIPELINE_FILTER = [
// 'deploy-getsentry-backend-s4s',
// 'deploy-getsentry-backend-s4s2',
// GOCD_SENTRYIO_BE_PIPELINE_NAME,
// GOCD_SENTRYIO_FE_PIPELINE_NAME,
// ];
Expand Down
1 change: 0 additions & 1 deletion src/brain/gocd/gocdNoDeploysAlert/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
import { getLastGetSentryGoCDDeploy } from '@/utils/db/getLatestDeploy';

const PIPELINE_FILTER = [
'deploy-getsentry-backend-s4s',
Copy link
Copy Markdown
Member

@hubertdeng123 hubertdeng123 Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be replaced with s4s2? or no

Copy link
Copy Markdown
Member Author

@kenzoengineer kenzoengineer Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the 3 checks failing alert that covers s4s2 i think thats fine for now

we never had alerting for this for s4s2 to begin with and nobody has complianed

GOCD_SENTRYIO_BE_PIPELINE_NAME,
GOCD_SENTRYIO_FE_PIPELINE_NAME,
];
Expand Down
16 changes: 8 additions & 8 deletions src/brain/gocd/gocdSlackFeeds/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ describe('gocdSlackFeeds', function () {
const gocdPayload = merge({}, payload, {
data: {
pipeline: {
name: 'deploy-getsentry-backend-s4s',
name: 'deploy-getsentry-backend-s4s2',
stage: {
name: 'soak-time',
result: 'Failed',
Expand All @@ -315,16 +315,16 @@ describe('gocdSlackFeeds', function () {
blocks: [
slackblocks.header(
slackblocks.plaintext(
':double_vertical_bar: deploy-getsentry-backend-s4s has been paused'
':double_vertical_bar: deploy-getsentry-backend-s4s2 has been paused'
)
),
slackblocks.section(
slackblocks.markdown(`The deployment pipeline has been paused due to detected issues in soak-time. Here are the steps you should follow to address the situation:\n
:mag_right: *Step 1: Review the Errors*\n Review the errors in the *<https://deploy.getsentry.net/go/tab/build/detail/deploy-getsentry-backend-s4s/20/soak-time/1/soak|GoCD Logs>*.\n
:mag_right: *Step 1: Review the Errors*\n Review the errors in the *<https://deploy.getsentry.net/go/tab/build/detail/deploy-getsentry-backend-s4s2/20/soak-time/1/soak|GoCD Logs>*.\n
:sentry: *Step 2: Check Sentry Release*\n Check the *<https://sentry-st.sentry.io/releases/backend@2b0034becc4ab26b985f4c1a08ab068f153c274c/?project=1513938|Sentry Release>* for any related issues.\n
:thinking_face: *Step 3: Is a Rollback Necessary?*\nDetermine if a rollback is necessary by reviewing our *<${IS_ROLLBACK_NECESSARY_LINK}|Guidelines>*.\n
:arrow_backward: *Step 4: Rollback Procedure*\nIf a rollback is necessary, use the *<${ROLLBACK_PLAYBOOK_LINK}|GoCD Playbook>* or *<${GOCD_USER_GUIDE_LINK}|GoCD User Guide>* to guide you.\n
:arrow_forward: *Step 5: Unpause the Pipeline*\nWhether or not a rollback was necessary, make sure to *<https://deploy.getsentry.net/go/pipeline/activity/deploy-getsentry-backend-s4s|unpause the pipeline>* once it is safe to do so.`)
:arrow_forward: *Step 5: Unpause the Pipeline*\nWhether or not a rollback was necessary, make sure to *<https://deploy.getsentry.net/go/pipeline/activity/deploy-getsentry-backend-s4s2|unpause the pipeline>* once it is safe to do so.`)
),
slackblocks.context(
slackblocks.markdown(
Expand All @@ -341,7 +341,7 @@ describe('gocdSlackFeeds', function () {
color: Color.DANGER,
blocks: [
slackblocks.section(
slackblocks.markdown('*sentryio/deploy-getsentry-backend-s4s*')
slackblocks.markdown('*sentryio/deploy-getsentry-backend-s4s2*')
),
{
elements: [
Expand All @@ -356,7 +356,7 @@ describe('gocdSlackFeeds', function () {
elements: [
slackblocks.markdown('❌ *soak-time*'),
slackblocks.markdown(
'<https://deploy.getsentry.net/go/pipelines/deploy-getsentry-backend-s4s/20/soak-time/1|Failed>'
'<https://deploy.getsentry.net/go/pipelines/deploy-getsentry-backend-s4s2/20/soak-time/1|Failed>'
),
],
},
Expand Down Expand Up @@ -425,7 +425,7 @@ describe('gocdSlackFeeds', function () {
color: Color.SUCCESS,
blocks: [
slackblocks.section(
slackblocks.markdown('*sentryio/deploy-getsentry-backend-s4s*')
slackblocks.markdown('*sentryio/deploy-getsentry-backend-s4s2*')
),
{
elements: [
Expand All @@ -440,7 +440,7 @@ describe('gocdSlackFeeds', function () {
elements: [
slackblocks.markdown('✅ *soak-time*'),
slackblocks.markdown(
'<https://deploy.getsentry.net/go/pipelines/deploy-getsentry-backend-s4s/20/soak-time/1|Passed>'
'<https://deploy.getsentry.net/go/pipelines/deploy-getsentry-backend-s4s2/20/soak-time/1|Passed>'
),
],
},
Expand Down
1 change: 0 additions & 1 deletion src/brain/gocd/gocdSlackFeeds/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ enum PauseCause {

// TODO: consolidate constants for regions
const BACKEND_PIPELINE_FILTER = [
'deploy-getsentry-backend-s4s',
'deploy-getsentry-backend-de',
'deploy-getsentry-backend-us',
'deploy-getsentry-backend-s4s2',
Expand Down
5 changes: 0 additions & 5 deletions src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,11 +222,6 @@ export const OFFICES_24_HOUR = ['vie', 'ams', 'yyz'];
export const OFFICES_12_HOUR = ['sfo', 'sea'];

export const GOCD_PAUSED_PIPELINE_REMINDERS: GoCDPausedPipelineReminder[] = [
{
pipelineName: 'deploy-getsentry-backend-s4s',
slackChannel: DISCUSS_BACKEND_CHANNEL_ID,
notifyAfter: moment.duration(1.5, 'hour'),
},
{
pipelineName: 'deploy-getsentry-backend-de',
slackChannel: DISCUSS_BACKEND_CHANNEL_ID,
Expand Down
2 changes: 1 addition & 1 deletion test/payloads/gocd/gocd-stage-checks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"data": {
"pipeline": {
"name": "deploy-getsentry-backend-s4s",
"name": "deploy-getsentry-backend-s4s2",
"counter": "2373",
"group": "getsentry-backend",
"build-cause": [
Expand Down
Loading