Skip to content

chore(s4s): Remove s4s alerting for getsentry/sentry#972

Merged
kenzoengineer merged 1 commit intomainfrom
kjiang/remove-s4s-sentry
Apr 14, 2026
Merged

chore(s4s): Remove s4s alerting for getsentry/sentry#972
kenzoengineer merged 1 commit intomainfrom
kjiang/remove-s4s-sentry

Conversation

@kenzoengineer
Copy link
Copy Markdown
Member

@kenzoengineer kenzoengineer commented Apr 14, 2026

We are deprecating s4s, which is causing a lot of noisy alerts in slack.

This PR removes mentions of s4s in sentry. In a later PR, we can remove it from sns (snuba, etc.)

@kenzoengineer kenzoengineer requested a review from a team April 14, 2026 21:00
import { getLastGetSentryGoCDDeploy } from '@/utils/db/getLatestDeploy';

const PIPELINE_FILTER = [
'deploy-getsentry-backend-s4s',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be replaced with s4s2? or no

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the 3 checks failing alert that covers s4s2 i think thats fine for now

we never had alerting for this for s4s2 to begin with and nobody has complianed

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.17%. Comparing base (1462beb) to head (8491cd5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   89.17%   89.17%           
=======================================
  Files         125      125           
  Lines        3899     3899           
  Branches      803      801    -2     
=======================================
  Hits         3477     3477           
+ Misses        408      387   -21     
- Partials       14       35   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mchen-sentry mchen-sentry self-requested a review April 14, 2026 21:18
@kenzoengineer kenzoengineer merged commit f2cf3b1 into main Apr 14, 2026
15 checks passed
@kenzoengineer kenzoengineer deleted the kjiang/remove-s4s-sentry branch April 14, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants