chore(s4s): Remove s4s alerting for getsentry/sentry#972
Merged
kenzoengineer merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
| import { getLastGetSentryGoCDDeploy } from '@/utils/db/getLatestDeploy'; | ||
|
|
||
| const PIPELINE_FILTER = [ | ||
| 'deploy-getsentry-backend-s4s', |
Member
There was a problem hiding this comment.
should this be replaced with s4s2? or no
Member
Author
There was a problem hiding this comment.
we have the 3 checks failing alert that covers s4s2 i think thats fine for now
we never had alerting for this for s4s2 to begin with and nobody has complianed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 125 125
Lines 3899 3899
Branches 803 801 -2
=======================================
Hits 3477 3477
+ Misses 408 387 -21
- Partials 14 35 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mchen-sentry
approved these changes
Apr 14, 2026
hubertdeng123
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are deprecating s4s, which is causing a lot of noisy alerts in slack.
This PR removes mentions of s4s in sentry. In a later PR, we can remove it from sns (snuba, etc.)