fix(setup): handle read-only .claude directory in sandboxed environments#702
Merged
fix(setup): handle read-only .claude directory in sandboxed environments#702
Conversation
…nts (#699) Add a writability pre-check (accessSync W_OK) in installAgentSkills() before attempting file creation. Some sandboxes (e.g., Claude Code) make ~/.claude read-only and may terminate the process on write syscalls, bypassing the existing try/catch. Also report setup step failures to Sentry via captureException in bestEffort() and the agent-skills catch block so we have visibility into installation errors that were previously silently swallowed.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Dashboard
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Codecov Results 📊✅ 134 passed | Total: 134 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1523 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.48% 95.36% -0.12%
==========================================
Files 224 225 +1
Lines 32591 32790 +199
Branches 0 0 —
==========================================
+ Hits 31115 31267 +152
- Misses 1476 1523 +47
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #699
accessSync(W_OK)pre-check ininstallAgentSkills()before attempting file creation — prevents sandbox process termination when~/.claudeis read-onlycaptureExceptioninbestEffort()and the agent-skills catch block for visibility into errors that were previously silently swallowed.claudedirectory with0o555permissions)