Skip to content

chore: bump rustreexo#882

Merged
Davidson-Souza merged 1 commit intogetfloresta:masterfrom
Davidson-Souza:bump-rustreexo
Mar 17, 2026
Merged

chore: bump rustreexo#882
Davidson-Souza merged 1 commit intogetfloresta:masterfrom
Davidson-Souza:bump-rustreexo

Conversation

@Davidson-Souza
Copy link
Copy Markdown
Member

@Davidson-Souza Davidson-Souza commented Mar 11, 2026 •
edited
Loading

Description and Notes

This PR updates rustreexo to main + mit-dci/rustreexo#104

I'll leave this as draft until we ship the next version, but this should help testing mit-dci/rustreexo#104

This PR bumps rustreexo v0.4.0 -> v0.5.0

@Davidson-Souza Davidson-Souza added this to the v0.9.0 milestone Mar 11, 2026
@Davidson-Souza Davidson-Souza self-assigned this Mar 11, 2026
@Davidson-Souza Davidson-Souza added dependencies Pull requests that update a dependency file chore Cleaning, refactoring, reducing complexity labels Mar 11, 2026
@Davidson-Souza Davidson-Souza mentioned this pull request Mar 11, 2026
Closed
20 tasks
@csgui csgui added this to Floresta Mar 12, 2026
@github-project-automation github-project-automation bot moved this to Backlog in Floresta Mar 12, 2026
@csgui csgui moved this from Backlog to In progress in Floresta Mar 12, 2026
@csgui csgui removed the chore Cleaning, refactoring, reducing complexity label Mar 12, 2026
@luisschwab
Copy link
Copy Markdown
Member

luisschwab commented Mar 14, 2026

This one is needed for SwiftSync IBD, right?

@JoseSK999
Copy link
Copy Markdown
Member

JoseSK999 commented Mar 14, 2026

Nope, this is needed for utreexod:0.5.0 compatibility. Currently we get “missing sibling” errors when we receive the uproofs.

@luisschwab
Copy link
Copy Markdown
Member

luisschwab commented Mar 14, 2026

Nope, this is needed for utreexod:0.5.0 compatibility. Currently we get “missing sibling” errors when we receive the uproofs.

That's what I thought, I'm testing IBD and proofs are being marked as invalid.

@JoseSK999
Copy link
Copy Markdown
Member

JoseSK999 commented Mar 14, 2026 •
edited
Loading

It should work with this branch + your BIP183 PR (@Davidson-Souza rebase plz)

@luisschwab
Copy link
Copy Markdown
Member

luisschwab commented Mar 14, 2026

It should work with this branch + your BIP183 PR (@Davidson-Souza rebase plz)

Let's see what happens xD

@Davidson-Souza
Copy link
Copy Markdown
Member Author

Davidson-Souza commented Mar 15, 2026

Rebased

@luisschwab
Copy link
Copy Markdown
Member

luisschwab commented Mar 15, 2026

It seems to be working 👀

@JoseSK999
Copy link
Copy Markdown
Member

JoseSK999 commented Mar 16, 2026

This worked for me as well, synced signet

@Davidson-Souza Davidson-Souza marked this pull request as ready for review March 17, 2026 17:27
@Davidson-Souza
Copy link
Copy Markdown
Member Author

Davidson-Souza commented Mar 17, 2026

rustreexo 0.5.0 published! This is now ready for review!

@luisschwab
Copy link
Copy Markdown
Member

luisschwab commented Mar 17, 2026

LGTM, will ACK once CI is green.

moisesPompilio
moisesPompilio approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@moisesPompilio moisesPompilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3c3a939

JoseSK999
JoseSK999 reviewed Mar 17, 2026
View reviewed changes
crates/floresta-chain/src/pruned_utreexo/consensus.rs
@@ -501,7 +500,10 @@ impl Consensus {
}
Copy link
Copy Markdown
Member

@JoseSK999 JoseSK999 Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer able to do this?

Copy link
Copy Markdown
Member Author

@Davidson-Souza Davidson-Souza Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do what? 😂

Copy link
Copy Markdown
Member

@luisschwab luisschwab Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer able to do this?

This what? I don't see any highlighted lines on your review.

Copy link
Copy Markdown
Member

@JoseSK999 JoseSK999 Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wtf, I just commented a deleted line. I mean the Into::into for the BitcoinNodeHash conversion, no longer possible I see

Copy link
Copy Markdown
Member Author

@Davidson-Souza Davidson-Souza Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is due to rustreexo using a different version of bitcoin-hashes than rust-bitcoin. Rust seems them as two different types. Rustreexo do implement that from, but until rust-bitcoin bumps their version, we can't really use it :/

Copy link
Copy Markdown
Member

@JoseSK999 JoseSK999 Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cooked

luisschwab
luisschwab approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 3c3a939

Successfully IBD'd on Signet!

@JoseSK999
Copy link
Copy Markdown
Member

JoseSK999 commented Mar 17, 2026

Verified with the #885 pinned deps this cargo.lock: only anstyle and cc versions differ

@Davidson-Souza
Copy link
Copy Markdown
Member Author

Davidson-Souza commented Mar 17, 2026

Verified with the #885 pinned deps this cargo.lock: only anstyle and cc versions differ

Do you think we better not update them? I don't think rustreexo forced this

JoseSK999
JoseSK999 approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@JoseSK999 JoseSK999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3c3a939; I had previously synced signet in this branch and currently it is still working for me (given I connect a good bridge)

@JoseSK999
Copy link
Copy Markdown
Member

JoseSK999 commented Mar 17, 2026

Verified with the #885 pinned deps this cargo.lock: only anstyle and cc versions differ

Do you think we better not update them? I don't think rustreexo forced this

We agreed not updating anstyle, and cc is also likely recent bump. It is fine IMO.

@Davidson-Souza Davidson-Souza merged commit 6c1dee0 into getfloresta:master Mar 17, 2026
11 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Floresta Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@JoseSK999 JoseSK999 JoseSK999 approved these changes

@moisesPompilio moisesPompilio moisesPompilio approved these changes

@luisschwab luisschwab luisschwab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Davidson-Souza Davidson-Souza

Labels

dependencies Pull requests that update a dependency file

Projects

Floresta
Status: Done

Milestone

v0.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Davidson-Souza @luisschwab @JoseSK999 @moisesPompilio @csgui