0.9.0 priorities

[Davidson-Souza]

As discussed in recent meetings, we should release 0.9.0 soon. Ideally by the end of this month. What should we prioritize on reviews for the next weeks? I would like to avoid big features for now, just bugfixes and minor improvements.

We decided that Swift Sync should be in the next release, I think the filters refactors also should be there. So the main changes I look forward for that release are:

• fix: several improvements to how AddrMan works #781
• feat(wire): introduce RequestSelection #828
• fix(chain_selector): fix a bug where we can sometimes get stuck and don't download any extra header #847
• fix: invalidate blocks with invalid transactions, and ban bad/malicious utreexo peers #852
• Consider dual licensing this project under MIT or Apache-2.0 #859
• Feat: add Manual type to ConnectionKinds #866
• feat(wire): create connections in batch #865
• Use core::str and core::fmt instead of std::* #876
• Update service_flags to use BIP-0183 values #877
• Add P2PV2 workaround and remove P2PV1 exception for Utreexo peers #878
• fix: two regressions that exposes our node to peer-induced DoS #880
• chore: bump rustreexo #882
• Implement a minimal Daemon and drop daemonize #898
• fix: make disconnect_and_ban actually ban #901
• chore: disable pow fraud proofs for this release #903
• fix: another bundle of small fixes for how we select peers #904
• Update ChainParams::get_assume_utreexo and ChainParams::get_assume_valid #905
• Test and update all hardcoded peers #907
• Add SUPPORTED_NETWORKS constant #908
• Bump bip324 to v0.10 #909

So people looking for things to review, please prioritize these. Any other PR that should also make it into this release? Please let me know

[JoseSK999]

Maybe also #804 so we remove kv entirely and add SQLite-db. Idk if this is a big feature tho.

[Davidson-Souza]

@JoseSK999 thanks for adding everything to the milestone.

Maybe also #804 so we remove kv entirely and add SQLite-db. Idk if this is a big feature tho.

ACK

Perhaps remove #588?

[jaoleal]

ACK

[moisesPompilio]

ACK

[luisschwab]

@Davidson-Souza make a checklist so we know what is completed.

No #774? :(

[Davidson-Souza]

@Davidson-Souza make a checklist so we know what is completed.

Done!

No #774? :(

I'm leaving for floripa tomorrow, I anticipate not being able to do that much coding in the mean time 😂

[jaoleal]

Theres any specific reason to release exactly by the end of february ?

[JoseSK999]

I would propose also having #852, as it fixes 4 important things:

• Currently we don't invalidate blocks that have a TransactionError.
• Currently a utreexo node can make us ban a honest node (see [Bug] bridge nodes can make us ban honest peers #851), and it's happening to us.
• Currently we don't ban bad/malicious utreexo peers.
• Currently we invalidate blocks with bad merkle root (mutated block), but we shouldn't since the original data may be valid.

[Davidson-Souza]

I propose adding #866 and #865 as well, they are relatively small and:

• Feat: add Manual type to ConnectionKinds #866 helps fixing an edge-case we might have (and fixes the whitelisting behavior for added peers)
• feat(wire): create connections in batch #865 adds a very useful UX IMO

[JoseSK999]

ACK especially batched connections

[luisschwab]

@Davidson-Souza you can add #875 as well

[Davidson-Souza]

I've been thinking; #821, #804 and #831 are major refactors, and software history shows that even with very dilligent review we still get some edge cases through. Since we wish to make a review by next week at most, I think those are too risky to be merged on this window. We should probably focus on testing and making sure everything is working. Then we add those to be the first thing next release.

Core calls this phase "feature freeze"

[jaoleal]

We need to add #880 too right ?