Skip to content

Comments

Port transform trait from geo and add a mutable flavor#109

Merged
bors[bot] merged 4 commits intomasterfrom
mkirk/transform
Feb 20, 2022
Merged

Port transform trait from geo and add a mutable flavor#109
bors[bot] merged 4 commits intomasterfrom
mkirk/transform

Conversation

@michaelkirk
Copy link
Member

@michaelkirk michaelkirk commented Feb 15, 2022

Fixes #101, #108

An alternative to #106, but as proposed in #108, I've done so by porting the Transform trait from geo to proj so that we won't need similar-but-different code in two places.

I chose to double down on a trait-based approach since it seemed idiomatic to our other georust code. However, like proposed in #106, I leveraged proj_array in more places.

/cc @x4d3

corresponding PRs:

@michaelkirk
Copy link
Member Author

michaelkirk commented Feb 16, 2022 via email

@frewsxcv
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 20, 2022

Build succeeded:

@bors bors bot merged commit c053622 into master Feb 20, 2022
@frewsxcv frewsxcv deleted the mkirk/transform branch February 20, 2022 00:50
bors bot added a commit to georust/geo that referenced this pull request Feb 20, 2022
730: Port Transform trait to `proj` crate. r=frewsxcv a=michaelkirk

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/master/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---
~~Based on the #729, so please review that first:~~: Done! Merged and rebased.

Depends on proj pr:
- georust/proj#109

Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the possibility to convert all the types from geo-types

2 participants