Merged
Conversation
This was referenced Feb 15, 2022
michaelkirk
force-pushed
the
mkirk/transform-redux
branch
from
bef5a81 to
8c4b590
Compare
bors bot
added a commit
to georust/proj
that referenced
this pull request
Feb 20, 2022
109: Port transform trait from geo and add a mutable flavor r=frewsxcv a=michaelkirk Fixes #101, #108 An alternative to #106, but as proposed in #108, I've done so by porting the [Transform trait from geo](georust/geo#718 ) to proj so that we won't need similar-but-different code in two places. I chose to double down on a trait-based approach since it seemed idiomatic to our other georust code. However, like proposed in #106, I leveraged proj_array in more places. /cc `@x4d3` corresponding PRs: - georust/geo#730 - frewsxcv/rgis#47 Co-authored-by: Michael Kirk <michael.code@endoftheworl.de>
frewsxcv
force-pushed
the
mkirk/transform-redux
branch
from
8c4b590 to
7c6bfbd
Compare
The trait was mostly lifted from geo and ported to proj. To it, I added: - a mutable (in place) version - versions that take a &Proj rather than an Into<Proj> so that we can re-use a proj instance and take advantage of proj_array in some contexts.
frewsxcv
force-pushed
the
mkirk/transform-redux
branch
from
7c6bfbd to
faf0a96
Compare
frewsxcv
approved these changes
Feb 20, 2022
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Based on the #729, so please review that first:: Done! Merged and rebased.Depends on proj pr: