Skip to content

Fix bug causing crash saving Relation resource #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregorjerse merged 2 commits into from
Nov 20, 2025
Merged

Fix bug causing crash saving Relation resource #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eeeeef
Fix bug causing crash saving Relation resource
gregorjerse Nov 19, 2025
86989a0
Prepare release 22.2.1
gregorjerse Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,17 @@ Change Log

All notable changes to this project are documented in this file.

==========
Unreleased
==========
===================
22.2.1 - 2025-11-19
===================

Fixed
-----
- Fix bug in ``get_or_run`` method
- Fix a bug in ``QCTables`` where the removal of sample name suffixes
in MultiQC ``.txt`` files leads to incorrect parsing of MACS prepeak tables
- Rewrite ``Collection`` shortcuts to use new syntax
- Fix a bug that caused crash when saving ``Relation`` resource


===================
Expand Down
5 changes: 5 additions & 0 deletions src/resdk/resources/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,11 @@ def __get__(
self._checks_before_get(instance)
return getattr(instance, self._value_attribute_name, None)

def changed(self, instance: "BaseResource") -> bool:
"""Check if the field value has changed."""
# Lazy resource fields are read-only so they can never be changed.
return False


class QueryRelatedField(LazyResourceField):
"""Lazy load resources from another resource query.
Expand Down
Loading