Fix bug causing crash saving Relation resource#399
Merged
gregorjerse merged 2 commits intogenialis:masterfrom Nov 20, 2025
Merged
Fix bug causing crash saving Relation resource#399gregorjerse merged 2 commits intogenialis:masterfrom
gregorjerse merged 2 commits intogenialis:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash that occurred when saving Relation resources. The fix implements a changed() method for LazyResourceField that always returns False, reflecting that lazy resource fields are read-only and cannot be modified.
Key changes:
- Added
changed()method toLazyResourceFieldclass - Updated changelog to document the bug fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/resdk/resources/fields.py | Implements changed() method for LazyResourceField to prevent crash when checking field modifications |
| docs/CHANGELOG.rst | Documents the bug fix for Relation resource saving crash |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jkokosar
approved these changes
Nov 19, 2025
gregorjerse
force-pushed
the
fix/relation_save
branch
from
d00657c to
86989a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.