Skip to content

Fixed a bug around cursors and updated nuget packages. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gehnster merged 1 commit into from
Feb 21, 2026
Merged

Fixed a bug around cursors and updated nuget packages. #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EVEStandard/API/APIBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ private static APIResponse ParseCursorInfo(APIResponse model)
{
using (var document = JsonDocument.Parse(model.JSONString))
{
if (document.RootElement.TryGetProperty("cursor", out var cursorElement))
if (document.RootElement.ValueKind == JsonValueKind.Object && document.RootElement.TryGetProperty("cursor", out var cursorElement))
{
Comment on lines +337 to 338
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor parsing is now guarded for object roots, but there’s no test coverage validating the original failure mode (a top-level JSON array response). Since many ESI endpoints return arrays, add a test asserting ProcessResponse succeeds and leaves Cursor null when the response body is e.g. "[]" (or "[1,2]").

Copilot uses AI. Check for mistakes.
model.Cursor = JsonSerializer.Deserialize<CursorInfo>(cursorElement.GetRawText());
}
Expand Down
8 changes: 4 additions & 4 deletions EVEStandard/EVEStandard.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.1;netstandard2.0</TargetFrameworks>
<Version>4.0.0</Version>
<Version>4.0.1</Version>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<NeutralLanguage>en-US</NeutralLanguage>
Expand All @@ -28,9 +28,9 @@
<ItemGroup>
<PackageReference Include="Macross.Json.Extensions" Version="3.0.0" />
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="6.0.1" />
<PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="6.35.1" />
<PackageReference Include="System.Text.Json" Version="6.0.11" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="10.0.3" />
<PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="8.16.0" />
<PackageReference Include="System.Text.Json" Version="10.0.3" />
</ItemGroup>

</Project>
Loading