Skip to content

Fixed a bug around cursors and updated nuget packages.#162

Merged
gehnster merged 1 commit intomasterfrom
bugfix-versionupdate
Feb 21, 2026
Merged

Fixed a bug around cursors and updated nuget packages.#162
gehnster merged 1 commit intomasterfrom
bugfix-versionupdate

Conversation

@gehnster
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 21, 2026 01:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a cursor-parsing failure in APIBase when responses aren’t JSON objects, and bumps the library/package dependencies along with the NuGet package version.

Changes:

  • Bump EVEStandard package version from 4.0.0 to 4.0.1.
  • Update several NuGet dependencies (Logging, JWT, System.Text.Json) to newer versions.
  • Fix cursor parsing to only attempt TryGetProperty("cursor", ...) when the JSON root is an object.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
EVEStandard/EVEStandard.csproj Updates package version and upgrades NuGet dependencies.
EVEStandard/API/APIBase.cs Guards cursor parsing to avoid failures when the JSON root isn’t an object.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +337 to 338
if (document.RootElement.ValueKind == JsonValueKind.Object && document.RootElement.TryGetProperty("cursor", out var cursorElement))
{
Copy link

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor parsing is now guarded for object roots, but there’s no test coverage validating the original failure mode (a top-level JSON array response). Since many ESI endpoints return arrays, add a test asserting ProcessResponse succeeds and leaves Cursor null when the response body is e.g. "[]" (or "[1,2]").

Copilot uses AI. Check for mistakes.
@gehnster gehnster merged commit f911dbe into master Feb 21, 2026
5 checks passed
@gehnster gehnster deleted the bugfix-versionupdate branch February 21, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants