Skip to content

Replace deprecated Error::description() with thiserror #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcomte merged 1 commit into from
Mar 30, 2026
Merged

Replace deprecated Error::description() with thiserror #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions src/cli_input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ use clap::Parser;
use colored::*;
use regex::Regex;
use si_unit_prefix::SiUnitPrefix;
use std::error::Error;
use std::fmt;
use std::num::ParseFloatError;

use crate::currencies::Currencies;
Expand Down Expand Up @@ -35,7 +33,8 @@ pub struct CliInput {
pub integer: bool,
}

#[derive(Debug)]
#[derive(Debug, thiserror::Error)]
#[error("{details}")]
pub struct InputError {
details: String,
}
Expand All @@ -48,18 +47,6 @@ impl InputError {
}
}

impl fmt::Display for InputError {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "{}", self.details)
}
}

impl Error for InputError {
fn description(&self) -> &str {
&self.details
}
}

impl From<ParseFloatError> for InputError {
fn from(err: ParseFloatError) -> Self {
Self::new(&err.to_string())
Expand Down
Loading