Skip to content

Replace deprecated Error::description() with thiserror#501

Merged
gcomte merged 1 commit intomasterfrom
fix/remove-deprecated-error-description
Mar 30, 2026
Merged

Replace deprecated Error::description() with thiserror#501
gcomte merged 1 commit intomasterfrom
fix/remove-deprecated-error-description

Conversation

@gcomte
Copy link
Copy Markdown
Owner

@gcomte gcomte commented Mar 30, 2026

Summary

  • Remove deprecated Error::description() impl from InputError
  • Use thiserror derive macro instead, matching CurrencyParseError's approach
  • Remove manual Display and Error impls (now generated by thiserror)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Warning

Rate limit exceeded

@gcomte has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 29 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 29 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 46a43689-249c-4bf6-b2e1-e1505ebe97f6

📥 Commits

Reviewing files that changed from the base of the PR and between 31e01f9 and 14023a5.

📒 Files selected for processing (1)
  • src/cli_input.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-deprecated-error-description

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Use thiserror derive for InputError, matching the CurrencyParseError
approach. Removes the deprecated description() method and manual
Display/Error impls.
@gcomte gcomte force-pushed the fix/remove-deprecated-error-description branch from e3bc384 to 14023a5 Compare March 30, 2026 07:32
@gcomte gcomte merged commit 9dee5b6 into master Mar 30, 2026
7 checks passed
@gcomte gcomte deleted the fix/remove-deprecated-error-description branch March 30, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant