Added range limits to measurements which can be physically limited.#1631
Open
peci1 wants to merge 1 commit intogazebosim:sdf16from
Open
Added range limits to measurements which can be physically limited.#1631peci1 wants to merge 1 commit intogazebosim:sdf16from
peci1 wants to merge 1 commit intogazebosim:sdf16from
Conversation
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
I've added min/max range and resolution to measurements where it makes sense. In some cases, the
<range>tags were already there, so I've only replaced them by the refactored-out one.This is only a proof of concept, adding the tags to SDF files only. Once there is agreement where these tags make sense, I can proceed adding them to the implementation files.
What it the general rule for adding new tags to existing SDF spec (1.12 here)? Can it be done? Or should there be a "rolling" version of SDF where new features are added until a release is made?
Test it
No testing possible at this moment.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.Backports: If this is a backport, please use Rebase and Merge instead.