Open
Conversation
This was referenced Nov 29, 2023
added 3 commits
November 29, 2023 14:52
Copied Airspeed Sensor and renamed to Airflow - Also already added airflow code where airspeed is found made corresponding changes to fit airflow new index number for airflow sensor Added AirPressure header back Testing for airflow sensor implemented Add noise testing for airflow sensor Python implementation for Airflow Sensor Signed-off-by: henrykotze <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
henrykotze
force-pushed
the
airflow-sensor
branch
from
d9b58c4 to
dba65db
Compare
ahcorde
requested changes
Nov 29, 2023
|
|
||
| #include "sdf/AirFlow.hh" | ||
| #include "sdf/parser.hh" | ||
|
|
Collaborator
There was a problem hiding this comment.
include "sdf/Noise.hh", "sdf/Element.hh", "sdf/Errors.hh"
Author
There was a problem hiding this comment.
Is this necessary if its added in the /sdf/Airflow.hh header?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## sdf13 #1349 +/- ##
==========================================
- Coverage 87.58% 87.56% -0.02%
==========================================
Files 128 130 +2
Lines 17095 17184 +89
==========================================
+ Hits 14972 15048 +76
- Misses 2123 2136 +13 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Henry Kotzé <henry@flycloudline.com>
Signed-off-by: henrykotze <henry@flycloudline.com>
henrykotze
force-pushed
the
airflow-sensor
branch
from
e1db4ce to
9560bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This adds an airflow sensor. These sensors are generally used to measure wind and are ultrasonic devices, measuring the airflow speed and direction using the Doppler effect.
Here is some use cases of such sensors from a manufacturer sensor which we have used.
https://fttechnologies.com/case-studies.
This is part of a larger plan to support an airflow sensor in PX4. @dagar
The code is heavily based on the Airspeed Sensor: #1215 .
Test it
Test are added to ensure correct use.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.