Upgrading to doobie 1.0.0-RC1 (and Cats-Effect 3)#31
Merged
gaelrenoux merged 6 commits intomasterfrom Sep 10, 2021
Merged
Conversation
gaelrenoux
commented
Sep 5, 2021
| } | ||
| final def connectionFromJdbc(env: TranzactioEnv, connection: JdbcConnection): ZIO[Any, Nothing, Connection] = { | ||
| ZIO.runtime[TranzactioEnv].flatMap { implicit r: zio.Runtime[TranzactioEnv] => | ||
| ZIO.succeed[Connection] { |
Owner
Author
There was a problem hiding this comment.
@hmemcpy I'm using succeed instead of effectTotal here, because I don't think there's any effecting code going under the hood here. Am I missing something ?
gaelrenoux
commented
Sep 5, 2021
| val tran = Transactor(connection, connect, interp, Strategy.void) | ||
| Has(tran) | ||
| } | ||
| }.provide(env) |
Owner
Author
There was a problem hiding this comment.
@PawelJ-PL In your code, you used provideLayer, I think we can just use provide here.
There was a problem hiding this comment.
👍 I can't remember, what I used provideLayer 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, this is mostly a rebase from #28 with a few changes:
@hmemcpy @PawelJ-PL Your comments are especially welcomed.