Upgrading to doobie 1.0.0-M4 (and Cats Effect 3)#28
Upgrading to doobie 1.0.0-M4 (and Cats Effect 3)#28hmemcpy wants to merge 1 commit intogaelrenoux:masterfrom
Conversation
|
Thanks for the help! I'm not a fan of upgrading to a milestone version, though. I get that upgrading to Cats-Effect 3 would be nice, but I'd rather wait for the 1.0.0. The milestones have been coming pretty fast, I assume it won't be too long. |
|
Of course, no rush! I just tried to do the upgrade, since The only thing I'm not sure about is whether wrapping it with |
|
Maybe you could merge this into a separate branch and create a new milestone release for |
| import izumi.reflect.Tag | ||
| import zio.blocking.Blocking | ||
| import zio.interop.catz._ | ||
| import zio.interop.catz.implicits.rts |
There was a problem hiding this comment.
I would avoid importing this implicit inside library. It will cause, that default Blocker and Clock will be used. This can cause various problems. E.g. I use https://kamon.io/ so I have to provide my own ExecutionContexts (also for Blocking) and with this import the instrumentation does not work. I think in the library it would be better to require Blocking and Clock to be provided and then use it as in this example: https://github.com/zio/interop-cats#async (see note https://github.com/zio/interop-cats#easier-imports-at-a-cost)
|
Hi, what is the state ? could really use the new version asap |
|
I'm on holiday for a few more days, and not in a great situation to code (kids around and stuff). I'll come back to this probably on the 4th of september (I don't think I'll have time before). |
|
Replaced by #31 after rebasing on master and adding @PawelJ-PL's changes. |
5 participants
Fixes #27
The major change with doobie for CE3 is that Blocker is no longer a thing. I removed the Blocker, and all the tests seem to pass. I haven't changed any other interfaces.