Update for URL-based webhooks, and message formatting#9
Open
brendonrapp wants to merge 2 commits intofsalum:masterfrom
brendonrapp:master
Open
Update for URL-based webhooks, and message formatting#9brendonrapp wants to merge 2 commits intofsalum:masterfrom brendonrapp:master
brendonrapp wants to merge 2 commits intofsalum:masterfrom
brendonrapp:master
Conversation
|
Ping for new version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack has updated their Incoming Webhooks integration to use a single URL in place of the token-argument previously used.
This PR replaces
slack_tokenwithslack_webhook. It also eliminatesslack_url, as the team URL no longer factors into incoming webhooks.Additionally, this PR makes use of Slack's Attachments API to color the bar next to the message as red or green, based on the success or failure of the Puppet run. It also uses the JSON standard library to convert a Ruby hash into JSON in lieu of the backslash-heavy string literal.