New slack URL webhook & Puppet 4 fix#12
Open
martinbalint wants to merge 5 commits intofsalum:masterfrom
Open
Conversation
…rapp) Adds markdown processing to attachment text field (by brendonrapp) Fix syntax to work with Puppet 4
|
Tested this fix on a puppet master nunning on a |
|
The check_run module that this module declares as a dep has changed owners and the new owner has also made some changes as of v0.3.1 for puppet 4 compatibility. Would you be able to update the metadata.json to point at landcareresearch/check_run instead? |
|
Can confirm, using this solves a number of issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains: