Open
Conversation
Copy the form elements from upstream CKAN. We use the form fields in CKAN 2.10, which were refactored to simplify them and drop the infamous image-upload.js module in ckan/ckan#6227. The markup is clearly separated in three blocks: 1. Upload/Link buttons 2. File input + Remove button 3. URL input + Remove button The style classes have been prefixed to avoid clashes with the other `image-upload` field we have in the form (the schema one, which will eventually be replaced): `.resource-upload-field` -> `.ckan-resource-upload-field` `.btn-remove-url` -> `.btn-remove-url-upload` TODO: * Remove inline JS * Autopopulate name * Hook into upload logic
Collaborator
|
Ok, I got it. But the implementation will be a bit different because I'm not going to use the jquery and I will use svelte to handle the logic, ok? |
Member
Author
|
AFAICT there is no jquery used in the markup I added, except for the linked name field logic that yes, can of course be moved to svelte. (same for the inline click handlers if there is a better way of implementing them) |
Collaborator
I was talking about that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from ckan/ckanext-validation#83
Copy the form elements from upstream CKAN. I've used the form fields in CKAN 2.10, which were refactored to simplify them and drop the infamous
image-upload.jsmodule in ckan/ckan#6227.The markup is clearly separated in three blocks:
Clicking one of the Upload/Link buttons shows the relevant input field + remove button (for uploads, it triggers the file picker immediately). This is the standard behaviour from CKAN 2.10, which is replicated in the component:
create_resource.mp4
What is missing here is the Messages + Progress bar section, which I think should appear just below the inputs as shown in these crude mockups (we don't need to use emojis, we can use font awesome for instance):
The style classes have been copied verbatim from CKAN 2.10, but prefixed to avoid clashes with the other
image-uploadfield we have in the resource form (the resource schema one, which will eventually be replaced):.resource-upload-field->.ckan-resource-upload-field.btn-remove-url->.btn-remove-url-uploadTODO
namefield. This is done here in upstream CKAN