Update uploader widget to follow ckan 2.10 design

[aivuk]

No description provided.

[amercader]

@aivuk this is getting better, but there's one piece missing, which is that the buttons and controls should be mutually exclusive, i.e.

1. when you click a button, the relevant control appears (file or URL input) and the buttons disappear, and
2. when you click remove, the input is cleared and hidden, and the buttons re-appear

This is shown in the screencast included in #1:

create_resource.mp4

[aivuk]

@amercader sorry, I missed that in your mockup. I did the change now, but I did need to add the field label "Data" to the ckan-upload component (before it was written on the ckanext-validation upload scheming template https://github.com/frictionlessdata/ckanext-validation/blob/feature/80-new-upload-widget/ckanext/validation/templates/scheming/form_snippets/ckan_uploader.html#L12) and removed from the ckanext-validation, otherwise it will not be simple to remove it from the js upload. What do you think?

This is how it looks now:

Screencast.from.03-30-2023.12.27.25.PM.webm

[aivuk]

I have some questions about the behaviour of the 'remove' button. With the upload we add automatically the filename and the schema when I a file is uploaded. What to do when I click remove, delete the content from the schema, mime type and name? Currently the old names keep in the fields.

[amercader]

This is how it looks now:

Great, that'es exactly what I meant. The changes you mention make sense

What to do when I click remove, delete the content from the schema, mime type and name? Currently the old names keep in the fields.

The schema for sure. Check what happens in vanilla ckan with regards to name and format, but I think they are left there (which we might want to change tbh)

[amercader]

@aivuk some quick comments :

• I can't see any "File uploaded" message after a successful upload (or an error if there was one), is that missing? Or maybe is worth leaving the progress bar at 100% visible, basically just make sure that the user knows the file is updated at this point
  
• Is the "Waiting for data schema detection" showing up? maybe it's too fast to come up, in this case is fine
• There is an error with files too large (I think default max for CKAN is 100Mb). it's fine for the upload to fail but it should show an error
• I think we could implement the same inferring logic if the user enters a URL (using a lose focus event or something)
• Clicking the "Remove" button should clear the name, format and schema, if any

And one pending issue is the cleanup of unfinished resources. I think that should happen we clicking the "Remove" button or leaving the page. Both should ping an endpoint that calls "resource_delete" (I think there's a builtin CKAN core one, maybe we can just call that one)
For the "leaving the page" scenario we could leverage the onbeforeupload event, which could be regitered only if we have uploaded a file / added a URL. Can you make some tests to see if it works?