Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 22 22
Lines 1362 1418 +56
=====================================
- Misses 1362 1418 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pyrco
suggested changes
Sep 19, 2024
43a0805 to
671d802
Compare
Co-authored-by: pyrco <105293448+pyrco@users.noreply.github.com>
671d802 to
7a4b3e1
Compare
CodSpeed Performance ReportMerging #31 will degrade performances by 27.14%Comparing Summary
Benchmarks breakdown
|
7a4b3e1 to
2ca63aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly experimental for now and requires benchmarking and profiling to see it it's worth pursuing this further. In some initial tests this turns out to be slower, but that's probably also because the rest of the chain (all containers and Dissect implementations) will use the
_readfallback.Also looks like PyPy is not happy about using
memoryview.The goal of this PR is to have a branch with which further testing can be performed to see if this is worthwhile.