Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 61.62% 68.32% +6.69%
==========================================
Files 27 29 +2
Lines 2356 2867 +511
==========================================
+ Hits 1452 1959 +507
- Misses 904 908 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
twiggler
requested changes
Sep 25, 2024
Contributor
twiggler
left a comment
twiggler
left a comment
There was a problem hiding this comment.
Great first take on supporting such a rather complex backup format.
twiggler
previously approved these changes
Nov 5, 2024
Contributor
twiggler
left a comment
twiggler
left a comment
There was a problem hiding this comment.
Tested against backup of windows VM.
Same results as official extract tool
- One nicpick (rename
tmpvariable) - There are linting issues
Member
Author
|
Will fix those last things and as discussed make a new PR on dissect.archive with the same code. |
Co-authored-by: twiggler <12800443+twiggler@users.noreply.github.com>
Contributor
|
Closed, merged into fox-it/dissect.archive#8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In collaboration with @joost-j <3
This PR adds initial support for Veeam Backup files. Only full, unencrypted backup files are supported at the moment. Support for incremental and encrypted backups will be added at a later date (this was enough work as it is!).
This took some long reverse engineering, so some things may not be 100% correct. The format supports some other features as well (other compression types, external files, some special block types) but we're not yet sure how to generate files that contain those, so those features are also not yet supported.
This also extends the
vma-extractutility to allow extraction of both VMA and VBK files.The performance is untested but it seems quick enough for normal usage. Performance suggestions are welcome by the reviewer.