Support preservation of symlinks for non-windows systems when using cp#1635
Open
cochaviz wants to merge 2 commits intofox-it:mainfrom
Open
Support preservation of symlinks for non-windows systems when using cp#1635cochaviz wants to merge 2 commits intofox-it:mainfrom
cp#1635cochaviz wants to merge 2 commits intofox-it:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support preservation of symlinks for non-windows systems when using
cpAs introduced in #1078, symlinks are not preserved, but this also includes other attributes which might be relevant for forensics. This PR introduces, firstly, support for preserving symlinks specifically, but could also include other attributes such as
owner,timestamp, etc.Proposed Changes
We want to introduce the various flags and options that
cpsupports for preserving flags (which are weirdly numerous? https://www.man7.org/linux/man-pages/man1/cp.1.html):This addition allows all the above variations, showing warnings when the included attribute is no supported:
Which preserves the
linksattribute. Here an example of an unsupported attribute:Closes #1636.
Checklist
related issue number