Skip to content

Remove checks for config management #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yuvania wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove checks for config management #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d8fe9f
remove checks for config management
Yuvania Sep 22, 2023
68a78b0
remove checks for config management
Yuvania Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions pantheon-deploy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ if [[ ! -d "$DIR" ]]; then DIR="$PWD"; fi
. "$DIR/functions/pantheon-get-framework"
. "$DIR/functions/pantheon-env-merge"
. "$DIR/functions/drupal/drupal-check-features"
. "$DIR/functions/drupal8/drupal8-check-config-management"
. "$DIR/functions/speak-message"

#set -x
Expand Down Expand Up @@ -55,12 +54,6 @@ case $FRAMEWORK in
drupal_check_features "$SITENAME" "$SOURCEENV"
hasfeatures=$?
;;

drupal8)
Comment on lines -58 to -59
Copy link
Copy Markdown
Contributor

@dalin- dalin- Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work like you're hoping. In bash/sh/zsh a case is the same as a PHP switch. So since you removed drupal8) then it will fall back to *) and get the message below: "This script has no configuration management automation...".

Instead I think you want to just leave the drupal8) section empty.

Copy link
Copy Markdown
Contributor Author

@Yuvania Yuvania Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalin- I understand, I understand, I'll do that, thanks for explaining in more detail

drupal8_check_config_management "$SITENAME" "$SOURCEENV"
hasconfigmanagement=$?
;;

*)
echo -e "This script has no configuration management automation for $FRAMEWORK. Unless this site has Quicksilver configured, you should probably just do everything manually."
;;
Expand Down
6 changes: 0 additions & 6 deletions pantheon-multidev-create
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ if [[ ! -d "$DIR" ]]; then DIR="$PWD"; fi
. "$DIR/functions/pantheon-script-colours"
. "$DIR/functions/pantheon-terminus-check"
. "$DIR/functions/drupal/drupal-check-features"
. "$DIR/functions/drupal8/drupal8-check-config-management"

# Uncomment for debugging.
#set -x
Expand All @@ -37,11 +36,6 @@ case $FRAMEWORK in
drupal)
drupal_check_features "$SITENAME" "$MULTIDEV"
;;

drupal8)
drupal8_check_config_management "$SITENAME" "$MULTIDEV"
;;

esac

URL=''
Expand Down
7 changes: 0 additions & 7 deletions pantheon-multidev-merge
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ if [[ ! -d "$DIR" ]]; then DIR="$PWD"; fi
. "$DIR/functions/pantheon-multidev-merge"
. "$DIR/functions/pantheon-multidev-delete"
. "$DIR/functions/drupal/drupal-check-features"
. "$DIR/functions/drupal8/drupal8-check-config-management"

#set -x

Expand All @@ -38,12 +37,6 @@ case $FRAMEWORK in
drupal_check_features "$SITENAME" "$MULTIDEV"
hasfeatures=$?
;;

drupal8)
drupal8_check_config_management "$SITENAME" "$MULTIDEV"
hasconfigmanagement=$?
;;

*)
echo -e "This script has no configuration management automation for $FRAMEWORK. Unless this site has Quicksilver configured, you should probably just do everything manually."
;;
Expand Down