Conversation
dalin-
left a comment
There was a problem hiding this comment.
You've done the first step here.
I totally regret writing this in BASH, because it's a language that values using fewer characters over clarity.
This first part
. "./some/directory"in PHP would be
include_once("./some/directory");I'm guessing that if you run this script with this change you'll get a fatal error.
So you also need to find further down where the function within that file is called and remove it.
dalin-
left a comment
There was a problem hiding this comment.
Overall I think we're making this change in the wrong place. The function drupal8_check_config_management (in functions/drupal8/drupal8-check-config-management) does 3 things:
- checks if the config module is installed (we want to remove this)
- checks if config split module is installed (we want to remove this)
- checks if config is overridden, if so gives some options about how to deal with it (we want to keep this).
So I think we only need to change that function, and not change the places that call that function.
|
|
||
| drupal8) |
There was a problem hiding this comment.
This won't work like you're hoping. In bash/sh/zsh a case is the same as a PHP switch. So since you removed drupal8) then it will fall back to *) and get the message below: "This script has no configuration management automation...".
Instead I think you want to just leave the drupal8) section empty.
There was a problem hiding this comment.
@dalin- I understand, I understand, I'll do that, thanks for explaining in more detail
This PR refers to this issue: #24