Skip to content

⚡ [Performance] Parallelize shader fetching in BloomPostProcessor #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ford442 merged 1 commit into from
Mar 26, 2026
Merged

⚡ [Performance] Parallelize shader fetching in BloomPostProcessor #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions public/utils/bloomPostProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@ export class BloomPostProcessor {

// Call once after construction
public async init() {
// Try to load shader code if not supplied
if (!this.thresholdShaderCode) {
this.thresholdShaderCode = await this.tryFetch(`${this.baseUrl}/shaders/bloom_threshold.wgsl`);
}
if (!this.blurShaderCode) {
this.blurShaderCode = await this.tryFetch(`${this.baseUrl}/shaders/bloom_blur.wgsl`);
}
if (!this.compositeShaderCode) {
this.compositeShaderCode = await this.tryFetch(`${this.baseUrl}/shaders/bloom_composite.wgsl`);
}
// Try to load shader code if not supplied, fetching concurrently if needed
const [t, b, c] = await Promise.all([
this.thresholdShaderCode ? Promise.resolve(this.thresholdShaderCode) : this.tryFetch(`${this.baseUrl}/shaders/bloom_threshold.wgsl`),
this.blurShaderCode ? Promise.resolve(this.blurShaderCode) : this.tryFetch(`${this.baseUrl}/shaders/bloom_blur.wgsl`),
this.compositeShaderCode ? Promise.resolve(this.compositeShaderCode) : this.tryFetch(`${this.baseUrl}/shaders/bloom_composite.wgsl`)
]);

this.thresholdShaderCode = t;
this.blurShaderCode = b;
this.compositeShaderCode = c;

// Create textures
const width = this.canvas.width;
Expand Down
20 changes: 10 additions & 10 deletions utils/bloomPostProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@ export class BloomPostProcessor {

// Call once after construction
public async init() {
// Try to load shader code if not supplied
if (!this.thresholdShaderCode) {
this.thresholdShaderCode = await this.tryFetch(`${this.baseUrl}/shaders/bloom_threshold.wgsl`);
}
if (!this.blurShaderCode) {
this.blurShaderCode = await this.tryFetch(`${this.baseUrl}/shaders/bloom_blur.wgsl`);
}
if (!this.compositeShaderCode) {
this.compositeShaderCode = await this.tryFetch(`${this.baseUrl}/shaders/bloom_composite.wgsl`);
}
// Try to load shader code if not supplied, fetching concurrently if needed
const [t, b, c] = await Promise.all([
this.thresholdShaderCode ? Promise.resolve(this.thresholdShaderCode) : this.tryFetch(`${this.baseUrl}/shaders/bloom_threshold.wgsl`),
this.blurShaderCode ? Promise.resolve(this.blurShaderCode) : this.tryFetch(`${this.baseUrl}/shaders/bloom_blur.wgsl`),
this.compositeShaderCode ? Promise.resolve(this.compositeShaderCode) : this.tryFetch(`${this.baseUrl}/shaders/bloom_composite.wgsl`)
]);

this.thresholdShaderCode = t;
this.blurShaderCode = b;
this.compositeShaderCode = c;

// Create textures
const width = this.canvas.width;
Expand Down
Loading