-
Notifications
You must be signed in to change notification settings - Fork 0
fix: improve DialogShell scroll, PageHeader layout, add HideBottomNav widget #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
4337d8b
fix: improve DialogShell scroll, PageHeader layout, add HideBottomNav…
anilcancakir 635af36
fix: address PR #19 review — revert breaking changes, rename HideBott…
anilcancakir 9ad6234
fix: wire MagicStarterHideBottomNav into AppLayout, export from barrel
anilcancakir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import 'package:flutter/widgets.dart'; | ||
|
|
||
| /// Signals to `MagicStarterAppLayout` that the bottom navigation bar | ||
| /// should be hidden for routes nested under this widget. | ||
| /// | ||
| /// Wrap a layout with this widget to suppress the mobile bottom navigation | ||
| /// bar for specific route groups (e.g., fullscreen views, media players, | ||
| /// chat screens). | ||
| /// | ||
| /// ## Usage | ||
| /// | ||
| /// ```dart | ||
| /// MagicRoute.group( | ||
| /// layout: (child) => MagicStarterHideBottomNav( | ||
| /// child: MagicStarter.view.makeLayout('layout.app', child: child), | ||
| /// ), | ||
| /// layoutId: 'app.fullscreen', | ||
anilcancakir marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /// routes: () { ... }, | ||
| /// ); | ||
| /// ``` | ||
| /// | ||
| /// In your layout's `build` method, check whether to show bottom nav: | ||
| /// | ||
| /// ```dart | ||
| /// if (!MagicStarterHideBottomNav.of(context)) _buildBottomNav(), | ||
| /// ``` | ||
| class MagicStarterHideBottomNav extends InheritedWidget { | ||
| /// Creates a [MagicStarterHideBottomNav] that hides bottom navigation | ||
| /// for its subtree. | ||
| const MagicStarterHideBottomNav({super.key, required super.child}); | ||
|
|
||
| /// Returns `true` if a [MagicStarterHideBottomNav] exists above [context]. | ||
| static bool of(BuildContext context) { | ||
| return context | ||
| .dependOnInheritedWidgetOfExactType<MagicStarterHideBottomNav>() != | ||
| null; | ||
| } | ||
|
|
||
| @override | ||
| bool updateShouldNotify(MagicStarterHideBottomNav oldWidget) => false; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.