fix: improve DialogShell scroll, PageHeader layout, add HideBottomNav widget#19
Merged
anilcancakir merged 3 commits intomainfrom Apr 4, 2026
Merged
fix: improve DialogShell scroll, PageHeader layout, add HideBottomNav widget#19anilcancakir merged 3 commits intomainfrom
anilcancakir merged 3 commits intomainfrom
Conversation
… widget - DialogShell: replace ListView with SingleChildScrollView for simpler scroll behavior, add ClipRRect to prevent body content overflow on rounded corners - PageHeader: refactor from nested WDiv flex layout to native Flutter Row + Expanded for more predictable sizing, add flex-wrap on actions - HideBottomNav: new InheritedWidget that signals AppLayout to hide bottom navigation for fullscreen routes
There was a problem hiding this comment.
Pull request overview
This PR aims to improve UI behavior in the Magic Starter Flutter plugin by adjusting dialog scrolling/clipping, refactoring the PageHeader layout for more predictable sizing, and introducing an inherited signal for hiding the bottom navigation in fullscreen routes.
Changes:
- Refactors
MagicStarterPageHeaderlayout from Wind flex classes to a FlutterRow/Expandedstructure and adds wrapping on actions. - Updates
MagicStarterDialogShellbody scrolling fromListView(shrinkWrap: true)toSingleChildScrollViewand adds rounded-corner clipping. - Adds a new
HideBottomNavInheritedWidgetintended to signal fullscreen layouts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| lib/src/ui/widgets/magic_starter_page_header.dart | Refactors header layout and actions container behavior. |
| lib/src/ui/widgets/magic_starter_dialog_shell.dart | Changes dialog body scrolling approach and adds clipping for rounded corners. |
| lib/src/ui/widgets/hide_bottom_nav.dart | Adds an inherited flag intended to hide bottom navigation for subtree routes. |
…omNav - Revert DialogShell to ListView(shrinkWrap: true) + structural classes, removing ClipRRect with hardcoded radius — fixes test expectation and preserves theme compatibility - Revert PageHeader to responsive Wind UI layout (flex-col sm:flex-row), restoring responsive behavior on small screens — fixes test expectation - Rename HideBottomNav → MagicStarterHideBottomNav with proper file naming (magic_starter_hide_bottom_nav.dart), add usage docs showing how to wire into layout
- AppLayout now checks MagicStarterHideBottomNav.of(context) before rendering bottomNavigationBar on mobile - Export MagicStarterHideBottomNav from magic_starter.dart barrel - Fix docblock: use backtick reference instead of unresolvable bracket link
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InheritedWidgetthat signalsMagicStarterAppLayoutto hide bottom navigation for fullscreen routes (e.g., chat views, media players). Wired intoAppLayout.bottomNavigationBarcheck and exported from the public barrel.Test plan
MagicStarterHideBottomNav.of(context)returnsfalseby defaultMagicStarterHideBottomNavhides bottom nav on mobileflutter analyze --no-fatal-infos— no issuesflutter test— all 578 tests pass