Skip to content

Comments

Copied Localized Metadata from Desktop File#37

Open
elsiehupp wants to merge 3 commits intoflathub:masterfrom
elsiehupp:patch-3
Open

Copied Localized Metadata from Desktop File#37
elsiehupp wants to merge 3 commits intoflathub:masterfrom
elsiehupp:patch-3

Conversation

@elsiehupp
Copy link
Contributor

Copied from mirall.desktop.in.

This is another thing you can do, so why not.

FYI I've already checked this with appstreamcli, and it validated, but I don't know how to put in placeholders for missing translations, i. e. the <description /> section.

@elsiehupp
Copy link
Contributor Author

Oh, it looks like this can be done with IntlTool, but I don't know how to set it up.

@flathubbot
Copy link
Contributor

Started test build 43425

@flathubbot
Copy link
Contributor

Build 43425 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41780/com.nextcloud.desktopclient.nextcloud.flatpakref

@flathubbot
Copy link
Contributor

Started test build 43429

@elsiehupp
Copy link
Contributor Author

I double-checked the guidelines from KDE:

https://community.kde.org/Guidelines_and_HOWTOs/AppStream

@flathubbot
Copy link
Contributor

Build 43429 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41784/com.nextcloud.desktopclient.nextcloud.flatpakref

@elsiehupp elsiehupp mentioned this pull request Mar 30, 2021
@elsiehupp
Copy link
Contributor Author

Strictly speaking, the <languages /> and <lang /> tags are meant to be used with a slightly different AppStream file, but this version still validates in appstreamcli...

@elsiehupp
Copy link
Contributor Author

Or maybe I got it from this link. I don't remember.

Copy link
Collaborator

@tilosp tilosp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this metainfo file should be added upstream.

Otherwise it hard to keep it in sync with the desktop file since they would be in different repos.
This would also benefit other distributions that currently have to maintain their own one (for example fedora).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants