Skip to content

Add Translation Tag#36

Open
elsiehupp wants to merge 3 commits intoflathub:masterfrom
elsiehupp:patch-2
Open

Add Translation Tag#36
elsiehupp wants to merge 3 commits intoflathub:masterfrom
elsiehupp:patch-2

Conversation

@elsiehupp
Copy link
Contributor

This is a feature of the AppStream specification, and it wouldn't hurt to add it.

@flathubbot
Copy link
Contributor

Started test build 43424

<release date="2019-07-22" version="2.5.3"/>
</releases>
<content_rating type="oars-1.1"/>
<translation type="gettext">https://www.transifex.com/nextcloud/nextcloud/</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the translation tag is not used for this. It's used to compute if your currently used language is available on that said app. If you want to link to where the user could contribute translations, you should use the url tag instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the XDG Appstream specification, that's not the case, unless Flathub works differently:

translate

URLs of this type should point to a webpage where users can submit or modify translations of the upstream project.

Typically this should be a link to the project page in Weblate, Transifex or Zanata, but could also be a link to an upstream-hosted wiki page describing how to send translations upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're looking at the url of type translate, not the translation tag here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that, too. I'm not sure what the difference is, considering:

<translation/> #

The <translation/> tag is an optional tag which can be added to specify the translation domain used for this software component. It may be used by the AppStream distro metadata generator to determine the translation status of the respective software (e.g. which languages the software is translated into and how complete the translations are).

I also used this as a reference for the <languages /> and <lang /> tags in my other pull request (strictly speaking it's for a different metadata file, though the file still validates with appstreamcli).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A late comment:

The translation URL shows the translation platform link.

sc 1

The translation tag determines whether to show the following banner if the translation file is not present, which states, "This app will appear in US English."

sc 2

Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<translation type="gettext">https://www.transifex.com/nextcloud/nextcloud/</translation>
<translation type="qt">translations/client_en.ts</translation>

would be correct but not achieve what was intended
not sure if the author is still active

@flathubbot
Copy link
Contributor

Build 43424 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41779/com.nextcloud.desktopclient.nextcloud.flatpakref

Sure, why not have both.
@flathubbot
Copy link
Contributor

Started test build 43433

@flathubbot
Copy link
Contributor

Build 43433 failed

@flathubbot
Copy link
Contributor

Started test build 43436

@flathubbot
Copy link
Contributor

Build 43436 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41789/com.nextcloud.desktopclient.nextcloud.flatpakref

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my inline comment

<release date="2019-07-22" version="2.5.3"/>
</releases>
<content_rating type="oars-1.1"/>
<translation type="gettext">https://www.transifex.com/nextcloud/nextcloud/</translation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<translation type="gettext">https://www.transifex.com/nextcloud/nextcloud/</translation>
<translation type="qt">translations/client_en.ts</translation>

would be correct but not achieve what was intended
not sure if the author is still active

<release date="2019-07-22" version="2.5.3"/>
</releases>
<content_rating type="oars-1.1"/>
<translation type="gettext">https://www.transifex.com/nextcloud/nextcloud/</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong usage of the tag.

@mgallien
Copy link
Collaborator

@elsiehupp do you still plan to work on this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants