Skip to content

Comments

Trimmed serendipity#23

Closed
jmv2009 wants to merge 80 commits intofiredrakeproject:trimmedSerendipityfrom
jmv2009:patch-2
Closed

Trimmed serendipity#23
jmv2009 wants to merge 80 commits intofiredrakeproject:trimmedSerendipityfrom
jmv2009:patch-2

Conversation

@jmv2009
Copy link

@jmv2009 jmv2009 commented May 27, 2021

This is an update to trimmedserendipity for flake compatibility. Afterwards, it could be pulled into master (or directly with #24, where contributions from the original authors are lost)

dham and others added 30 commits October 21, 2019 11:37
Remove pytest-cases dependency.
…re-element-weights

Allow a QuadratureElement to take in the weights.
Rather than using sympy.evalf on each basis function for each point,
use lambdify and splat the whole thing at once numerically. Takes
tabulation from hundreds of seconds to tenths of seconds.
…pity

serendipity: Massively speed up tabulation
Fix serendipity tabulation for non-3D cells
setup: Ignore ambiguous variable names for flake8
FabianL1908 and others added 14 commits July 14, 2020 12:12
…rpolation-nodes

Improved interpolation nodes for RT and N1curl elements.

Selected by specifying `variant="integral"` to the constructor.
lambdify doesn't preserve shape when the result is zero. Fixes
firedrakeproject/firedrake#1783.
…ity-derivs

Broadcast result of lambdify in Serendipity tabulation
Previously we advertised the interior integral moments as eating
functions with shape (). This is incorrect, and breaks creation of
RestrictedElements with only the interior dofs, since the dual space
construction fails [it expects the dual to eat functions of shape
(space_dimension, )].
…oment

N1curl: Correctly advertise shape of interior moments
Implement Arnold-Winther and Mardal-Tai-Winther elements

Co-authored-by: Patrick Farrell <patrick@pefarrell.org>
Co-authored-by: Francis Aznaran <francis.aznaran@gmail.com>
These are H1-conforming elements that admit diagonal mass matrices
at high order when combined with special quadrature schemes.

Co-authored-by: Rob Kirby <robert.c.kirby@gmail.com>
Add ability to construct a dual basis from a set of unisolvent points.

Useful for elements that are defined directly by tabulation.
* pointwise_dual: Get correct spatial dimension

* serendipity: Correct default entity

We need to use get_dimension so that this does the right thing on
tensor product cells.

* serendipity: Use flattened element to construct unisolvent points

* Add test of duals for serendipity in tensor and ufc element cases

Co-authored-by: Rob Kirby <robert.c.kirby@gmail.com>
* replaced $ in manual.rst file by :math:

* fix manual.rst
Implement numerical stable tabulation of (derivatives) of GL/GLL basis functions
using the second barycentric interpolation formula of Berrut and Trefethen (2004).
@jmv2009 jmv2009 marked this pull request as draft May 27, 2021 16:52
@jmv2009 jmv2009 closed this May 27, 2021
@jmv2009 jmv2009 reopened this May 27, 2021
This was referenced May 27, 2021
@rckirby
Copy link

rckirby commented Jun 27, 2022

Closing this one, as #24 has done an up-to-date merge with master.

@rckirby rckirby closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.