Merged
Conversation
…mbing for SminusDiv elements.
…dimensions being used by the elements.
…should be working correctly now for both 2 and 3 dimensions.
…l orders. Still need to test order 5 and 6 to make sure those work.
This was referenced May 10, 2021
|
Shall we review here, or the equivalent one in FEniCS#66? Eventually we will merge over there but we can do the review here instead if you like. |
Author
|
Fiatinterface.py and representation.py in fenics-ffc currently require a dual basis, which is not available yet. |
This was referenced May 22, 2021
Closed
rckirby
approved these changes
Jun 27, 2022
rckirby
left a comment
rckirby
left a comment
There was a problem hiding this comment.
Approved. We've been using this branch for papers and getting good results. I've brought it up to date with master and flake8'ed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add trimmed serendipity capability. (Finite Element Exterior Calculus, de Rahm Complex)
https://arxiv.org/abs/2104.12986 Crum et al.
https://arxiv.org/abs/1605.00132 Cornburn & Fu
Todo for 3D: Prisms, Pyramids
Also needs updated ufl, tsfc, FInAT
firedrakeproject/ufl#23
firedrakeproject/tsfc#248 -> firedrakeproject/tsfc#249
FInAT/FInAT#82 -> FInAT/FInAT#86
Refer to #23 and #24 for flake compatible versions.
Note: have runtested changes