Skip to content

Fall back gracefully when sum factorisation fails. #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dham wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fall back gracefully when sum factorisation fails. #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion finat/finiteelementbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,11 @@ def dual_evaluation(self, fn):
# ignoring any shape indices to avoid hitting the sum-
# factorisation index limit (this is a bit of a hack).
# Really need to do a more targeted job here.
evaluation = gem.optimise.contraction(evaluation, shape_indices)
try:
evaluation = gem.optimise.contraction(evaluation, shape_indices)
except NotImplementedError as e:
if str(e) != "Too many indices for sum factorisation!":
raise
return evaluation, basis_indices

@abstractproperty
Expand Down