Fall back gracefully when sum factorisation fails.#207
Draft
Conversation
The sum factorisation implementation only works with up to 6 indices in a contraction. There are circumstances in which an interpolation kernel can exceed this. Rather than failing in this case, we should not sum factorise.
|
As an alternative could we just have (here) if len(sum_indices) > 6:
logger.warning("That's a lot of indices you have there, this might take some time") |
Member
Author
Fair. |
Member
Author
|
Result of Firedrake meeting discussion:
|
Member
Author
|
Actually the proposed solution is not great. We'd have to pass the parameter through a whole load of code. Additionally, this changes the generated code, so in principle we should change the signature of that code. I think this is a mess for what is basically a hack in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sum factorisation implementation only works with up to 6 indices in a contraction. There are
circumstances in which an interpolation kernel can exceed this. Rather than failing in this case, we
should not sum factorise.