fix: refuse to process unsupported feature#354
Draft
0xalpharush wants to merge 2 commits intoagave-v3.0.0from
Draft
fix: refuse to process unsupported feature#3540xalpharush wants to merge 2 commits intoagave-v3.0.0from
0xalpharush wants to merge 2 commits intoagave-v3.0.0from
Conversation
Contributor
Author
|
I can run the vectors with the script locally, so I'm not sure why CI is failing |
Contributor
Author
|
The features hitting the panic I introduced are marked as unsupported in solfuzz-agave Should the features not be activated in the test-vectors or just not enabled for fuzzing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See firedancer-io/solana-conformance#148 for more context.
This doesn't ensure hardcoded features are activated, but it's helpful to validate inputs generated independently of solfuzz